In #2348543: [meta] Consensus Banana Phase 2, transition templates to the starterkit theme we moved a lot of templates from modules to Classy, the CSS that relies on the classes in Classy is still in the modules files
The css should follow the template, node.admin.css classes are all added in 'core/themes/classy/templates/content-edit/node-edit-form.html.twig'
Move the CSS that relies on the HTML classes for every module. Ensure that the classes aren't being added in the module.
None for Classy, Stark will be more Stark
None
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | move_node_admin-css-2491257-14.patch | 6.19 KB | chernous_dn |
| #10 | after.png | 66.99 KB | see15_aug |
| #10 | before.png | 69.47 KB | see15_aug |
| #8 | interdiff-2491257-3-7.txt | 704 bytes | manjit.singh |
| #7 | move-node-admin-css-2491257-7.patch | 6.38 KB | manjit.singh |
Comments
Comment #1
aliyakhan commented@morten Looks like the current css for the 'core/themes/classy/templates/content-edit/node-edit-form.html.twig' is coming from node.module.css and not in node.admin.css. Are we referring to that?
Comment #2
mortendk commentedthen we should also move that as the markup & css should follow each other else its gonna be such a mess to figure out where stuff comes from
module.css vs theme.css vs admin.css is not always accurate from the old days of Drupal7, so there very well be some major overlaps there.
So as a rule or thumb lets move the css with the markup :)
Comment #3
aliyakhan commentedMoved files, lets see how testbot behaves ;)
Comment #4
aliyakhan commentedComment #5
rudraram commentedComment #6
aliyakhan commentedComment #7
manjit.singhfound some issues, Attaching screenshots.
I am attaching a patch.. that can resolve this issue. :)
Comment #8
manjit.singhattaching interdiff of #3 and #7
Comment #10
see15_aug commentedAfter apply the patch #3 found issue as #7. Patch of #7 is working. Attached screenshot.
Comment #11
manjit.singhComment #14
chernous_dn commentedI moved two css file "node.module.css" and "node.admin.css" to theme classy, include to templates.
Comment #17
manjit.singhThanks @Chernous_dn for working on this.. let's wait for some more review as well.
Comment #18
lewisnymanThe direction in #2489460: [Meta] Move module.theme.css files to Classy or Seven is to move *.theme.css files only. We shouldn't be moving the module or the admin CSS files.