Problem/Motivation

User Interface text that the hook_help text for Filter module refers to has been changed since it got committed.
"Selecting filters" is now called "Enabling filters"

The functionality "enable the use of text formats by choosing "Filtered text (user selects text format)" " has been replaced by different six different text fields that are either formatted or not.

Proposed resolution

Replace the use "Enabling text formats for field editing" by explaining the different text fields.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#8 help-text-Filter-Module-2470946-7.patch3.46 KBbotris
#5 help-text-Filter-Module-2470946-5.patch3.46 KBbotris
#3 help-text-Filter-Module-2470946-3.patch7.79 KBbotris
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Issue tags: +Novice
botris’s picture

botris
Primary language Dutch
Location Creuse, France
CreditAttribution: botris commented
Issue tags: +drupaldevdays

Replace "Enabling text formats for field editing" with "Using text field with formatting".
Currently working on this.

botris’s picture

botris
Primary language Dutch
Location Creuse, France
CreditAttribution: botris commented
Status: Active » Needs review
FileSize
help-text-Filter-Module-2470946-3.patch7.79 KB

I've updated the text and inserted "Using text fields with text formats". I've used 'text formats' instead of 'formatting' as it seems more consistant with the rest of the headers on this help page.

Also removed the <p> tags under "Selecting filters" and replaced with two <dd> tags.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Needs review » Needs work

Thanks Boris,

the new text looks good, and for replacing the p tags with dd.

One last thing: there is an empty line befer "Using text fields with text formats" (line 40).
Could you remove that?

botris’s picture

botris
Primary language Dutch
Location Creuse, France
CreditAttribution: botris commented
FileSize
help-text-Filter-Module-2470946-5.patch3.46 KB

Line removed, also extra lines that where part of another patch...

botris’s picture

botris
Primary language Dutch
Location Creuse, France
CreditAttribution: botris commented
Status: Needs work » Needs review
ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Needs review » Needs work

and now I've spotted a typo, there is an "r" missitng.
are those with "fomatted" should be formatted

botris’s picture

botris
Primary language Dutch
Location Creuse, France
CreditAttribution: botris commented
Status: Needs work » Needs review
FileSize
help-text-Filter-Module-2470946-7.patch3.46 KB

fixed typo

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Needs review » Reviewed & tested by the community

Thanks!

Now it really should be done.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Looks good to me too, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: help-text-Filter-Module-2470946-7.patch, failed testing.

Status: Needs work » Needs review

jhodgdon queued 8: help-text-Filter-Module-2470946-7.patch for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

The test failure was a bot glitch.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed bf0ab07 on 8.0.x 
    Issue #2470946 by boris sondagh, ifrik: Update hook_help text for Filter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.