Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I ran the Code Review and these are the findings and fixes I made.
I manually do patches, so I'm just going to attach the files in question.
| Comment | File | Size | Author |
|---|---|---|---|
| update_D7.zip | 15.69 KB | Kebz | |
| codeR_Update_29MAR2015.jpg | 205.34 KB | Kebz |
Comments
Comment #1
darol100 CreditAttribution: darol100 as a volunteer and commented@Kebz, What is the update_D7.zip file ? If you are provide patches, you should add a patch without any compression.
Comment #2
cilefen CreditAttribution: cilefen commented@Kebz Thank you for contributing to Drupal. See making a Drupal patch with Git on how to create a patch. Also, please update the issue title and summary with exactly what the issue intends to fix.
Comment #3
dcam CreditAttribution: dcam as a volunteer commentedThere are existing D8 issues for making core pass coder review. They're not marked for backport though. Plus, since the code is so different between the major versions, it's likely that the patches would have little in common. Any discussion that occurred for D8 would probably have little relevance for D7. So while I would normally close something like this as a duplicate issue, it's probably ok to keep this one open.
Comment #4
dcam CreditAttribution: dcam as a volunteer commentedSorry, I meant to reference the Update-specific issue.