Problem/Motivation

The 'Add language' form uses no actions wrapper for its submit buttons. This results in inconsistent theming:

Proposed resolution

Use an 'actions' wrapper for theming consistency.
Consistently apply this to any other entity forms

Remaining tasks

  1. identify additional entity forms that don't use actions for their buttons
  2. patch to add them

User interface changes

The theming for forms is consistent in all entity forms

API changes

None

CommentFileSizeAuthor
#26 After2.png51.08 KBmohit1604
#26 After1.png30.48 KBmohit1604
#26 Before2.png50.96 KBmohit1604
#25 Before1.png30.27 KBmohit1604
#24 use-actions-wrapper-on-add-language-form-for-theming-consistency-2459547-24-D8.patch2.03 KBmohit1604
#21 use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-21.patch2.03 KBidebr
#19 use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-19.patch2.03 KBidebr
#17 use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-17.patch1.18 KBidebr
#9 2459547-2.png161.44 KBpjbaert
#9 2459547-1.png216.29 KBpjbaert
#9 use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-9.patch1.26 KBpjbaert
#3 2459547-3.patch1.26 KBidebr
#1 2459547-1-custom-language-after.png49.67 KBidebr
#1 2459547-1-after.png33.06 KBidebr
add-language-before.png35.88 KBidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr’s picture

idebr CreditAttribution: idebr commented
Status: Active » Needs review
FileSize
2459547-1-after.png33.06 KB
2459547-1-custom-language-after.png49.67 KB

Screenshot after:

Screenshot after (custom language...):

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Active
Related issues: +#2160621: Button spacing CSS is too fragile

Looks like we are missing a patch?

Also see: #2160621: Button spacing CSS is too fragile

idebr’s picture

idebr CreditAttribution: idebr commented
FileSize
2459547-3.patch1.26 KB

@LewisNyman Doh! Let's see if the patch still applies

idebr’s picture

idebr CreditAttribution: idebr commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 2459547-3.patch, failed testing.

Status: Needs work » Needs review

LewisNyman queued 3: 2459547-3.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2459547-3.patch, failed testing.

pivica’s picture

pivica CreditAttribution: pivica commented
Assigned: Unassigned » pivica

Checking this.

pjbaert’s picture

pjbaert
Primary language Dutch
CreditAttribution: pjbaert at XIO commented
Assigned: pivica » Unassigned
Status: Needs work » Needs review
Issue tags: +Barcelona2015
FileSize
use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-9.patch1.26 KB
2459547-1.png216.29 KB
2459547-2.png161.44 KB

I rerolled the patch.
The changes still look good.
Noticed that the color of the 'add language' & 'add custom language' buttons is different. But this is something we probably shouldn't fix in this patch?

blue button
white button

Status: Needs review » Needs work

The last submitted patch, 9: use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-9.patch, failed testing.

The last submitted patch, 9: use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-9.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

idebr’s picture

idebr CreditAttribution: idebr commented
Status: Needs work » Needs review
idebr’s picture

idebr CreditAttribution: idebr commented
Version: 8.3.x-dev » 8.4.x-dev
idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
FileSize
use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-17.patch1.18 KB

Reroll against 8.4.x

Status: Needs review » Needs work

The last submitted patch, 17: use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-17.patch, failed testing.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs work » Needs review
FileSize
use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-19.patch2.03 KB

Status: Needs review » Needs work

The last submitted patch, 19: use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-19.patch, failed testing.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs work » Needs review
FileSize
use_actions_wrapper_on_add_language_form_for_theming_consistency-2459547-21.patch2.03 KB

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mohit1604’s picture

mohit1604 CreditAttribution: mohit1604 as a volunteer commented
Assigned: Unassigned » mohit1604
mohit1604’s picture

mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commented
FileSize
use-actions-wrapper-on-add-language-form-for-theming-consistency-2459547-24-D8.patch2.03 KB

Thanks @idebr for working on this issue.
This Patch is for version 8.5.x .

mohit1604’s picture

mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commented
FileSize
Before1.png30.27 KB

Before applying patch

before_applying_patch

before_applying_patch

After applying patch

after_applying_patch

after_applying_patch

mohit1604’s picture

mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commented
FileSize
Before2.png50.96 KB
After1.png30.48 KB
After2.png51.08 KB

Uploading again all the remaining screenshots ! Don't know why it wasn't attached with previous comment !

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mohit1604’s picture

mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commented

Adding test for 8.6.x in patch #24.

mohit1604’s picture

mohit1604 CreditAttribution: mohit1604 at Google Summer of Code commented
Status: Needs review » Reviewed & tested by the community
star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented
Title: Use actions wrapper on 'Add language' form for theming consistency » Use actions wrapper on forms for theming consistency
Component: locale.module » forms system
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

Thanks all for the work here so far.

The scope feels too small (https://www.drupal.org/core/scope#incomplete). If we do update this, we should try to update other cases like this as well if consistency is the name of the game. For example \Drupal\Core\Entity\Plugin\EntityReferenceSelection\DefaultSelection has some buttons (only show up with JS disabled - can be seen at /admin/structure/types/manage/article/fields/node.article.field_tags on standard profile) that look like this too. forms system might not be quite the right component but it's a start. I didn't search exhaustively through core but found that example pretty quickly.

Patch from #21 still applies so the patch from #24 wasn't necessary. @mohit1604 thanks for all the testing, I'm going to interpret the RTBC as being for the patch in #21 (please don't RTBC your own patches).

idebr’s picture

idebr CreditAttribution: idebr at iO commented

#30 @Cottser It took 3 years to get a patch for a single form to RTBC. Per your comment this issue would have to identify and chase every form in HEAD, so I'll pass

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented

I agree with #31, we should get in what we can right now and open a new followup to find and fix the other remarks. Since this issue has already taken so long to finish, I hope we can reverse that decision and can commit #24.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Category: Bug report » Task
Issue summary: View changes
Issue tags: -Needs issue summary update +Bug Smash Initiative

Added issue summary update

I feel like this is a task too

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.