Problem/Motivation

SqlContentEntityStorage::invokeHook calls $this->invokeFieldMethod for presave. The $this->invokeFieldMethod method lives in ContentEntityStorageBase and I think this invokeHook override should as well.

Proposed resolution

Move up the method.

Remaining tasks

User interface changes

API changes

Alternative storage engines begin to work :)

CommentFileSizeAuthor
presave.patch1.48 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue tags: +Entity Field API, +Field API

Tags

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

It has nothing to do with SQL so moving it makes sense.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

I does, "preSave" hook should be executed for all entities not only sql-storage based

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 6c91bb7 and pushed to 8.0.x. Thanks!

  • alexpott committed 6c91bb7 on 8.0.x 
    Issue #2427001 by chx: field item presave is only called for SQL

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.