Random testbot fail: "The page does not have double escaped HTML tags." in Drupal\field_ui\Tests\ManageFieldsTest [#2424743]

neclimdul noted this in IRC on one of his patches at #2229145-119: Register symfony session components in the DIC and inject the session service into the request object, and now it's showing up on https://qa.drupal.org/8.0.x-status as well:

$error in line 89 of FieldUiTestTrait.php, Drupal\field_ui\Tests\ManageFieldsTest->fieldUIAddExistingField()$

Sending for re-test now.

Comment	File	Size	Author
	Screen Shot 2015-02-11 at 1.42.02 PM.png	42.73 KB	webchick

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 11 February 2015 at 21:45

Issue summary:

View changes

Comment #2

neclimdul

He/Him

CreditAttribution: neclimdul commented 12 February 2015 at 00:04

  public function fieldUIAddExistingField($bundle_path, $existing_storage_name, $label = NULL, array $field_edit = array()) {
    $label = $label ?: $this->randomString();
    $initial_edit = array(
      'existing_storage_name' => $existing_storage_name,
      'existing_storage_label' => $label,
    );

    // First step: 'Re-use existing field' on the 'Add field' page.
    $this->drupalPostForm("$bundle_path/fields/add-field", $initial_edit, t('Save and continue'));
    $this->assertNoRaw('&amp;lt;', 'The page does not have double escaped HTML tags.');

    // Second step: 'Field settings' form.
    $this->drupalPostForm(NULL, $field_edit, t('Save settings'));
    $this->assertRaw(t('Saved %label configuration.', array('%label' => $label)), 'Redirected to "Manage fields" page.');

    // Check that the field appears in the overview form.
    $this->assertFieldByXPath('//table[@id="field-overview"]//tr/td[1]', $label, 'Field was created and appears in the overview page.');
  }

First, why do we still use randomString()? We have no idea what we're testing :(.

If I'm reading this right we're checking that a random label is written and then we're failing because "<" is not double escaped in the output. I don't really know what that is trying to test but if it's trying to test that a label with a "<" in it is not double escaped its only going to correctly test that when the label randomly contains a "<"

Turns out if you make the label "&1e5&QE<" you get this in your output.
<title>&amp;1e5&amp;QE&lt; settings for Basic page | Drupal</title>

woops, double escaped.