Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This issue is a side issue from https://www.drupal.org/node/2417733
It contains some unrelated documentation flaws.
Most are very minor but I need to headline one. Which makes this a bug report rather than a task.
The documentation of twig_without() makes reference to a deleted parameter.
I have also inserted an array prefix into a few function parameter definitions. So this patch cannot be regarded as a documentation only patch.
Some test might fall over, but that is a good thing to know!
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-3-7.txt | 502 bytes | martin107 |
#7 | twig.engine-7.patch | 2.19 KB | martin107 |
#3 | interdiff-0-3.txt | 760 bytes | martin107 |
#3 | twig.engine-3.patch | 2.25 KB | martin107 |
twig.engine.patch | 2.24 KB | martin107 | |
Comments
Comment #2
joelpittetThanks for the clean-up.
This one isn't always an array, sometimes it's an object with ArrayAccess.
All the rest should work.
Comment #3
martin107 CreditAttribution: martin107 commentedAh rats - Backing out the change and updating the documentation.
Other parameter definitions specify array|object -but not many see _drupal_rewrite_settings_global()
Comment #4
joelpittetThanks one more thing, I think.
This needs to stay, it's correct and I wrote it:P
Comment #5
martin107 CreditAttribution: martin107 commented@joelpittet - Can I politely disagree...
The $args @param definition I want to removed relates to twig_without($element) not twig_render_var($arg)
$args is now internal to the function it set from a call to func_get_args()
Comment #6
joelpittet@martin107 yes, twig_without() function, you were there too:)
The main purpose of that function is those $args, because those are what the $element are doing 'without'. That's why they are documented.
https://www.drupal.org/node/2114563#comment-8554679
https://www.drupal.org/node/2114563#comment-8200265
Comment #7
martin107 CreditAttribution: martin107 commentedYou are right, I am complete wrong.
'cuse me while I wipe all that egg of my face :)
Comment #8
joelpittetNo worries, it's not documented in the coding standards, which would be nice.
This looks like a nice doc clean-up.
Comment #9
alexpottDocumentation is not frozen in the beta. Committed e5d8a95 and pushed to 8.0.x. Thanks!