Remove classes from system templates f*.html.twig

Postponing this until we decide how we are moving forward. Keep an eye on #2348543: [meta] Consensus Banana Phase 2, transition templates to the starterkit theme for updates. Thanks.

Un-postponing. The templates have been copied to Classy, so all we need to do is remove classes from the original templates.

I left a few classes. I'm not sure where we stand on things like form-required.

look through the css & js found a js- prefix for .form-disabled

looks like its testing on core and not classy ?

fixed test ensured they used classy to test on

Good job, @mortendk! Keep rocking!! \m/

Form elements BEFORE

Form elements AFTER

Something is feeling really wrong about prefixing everything that javascript touches with js- especially when the class is being used to give the element style.

Something is feeling really wrong about prefixing everything that javascript touches with js- especially when the class is being used to give the element style.

We need this sepration for the css to not accedentially removing / overwriting somebody thats needed / provided from the js.

This means that we need to refactor the js stuff & also clean up the css to follow our codestandards

after looking at the templates, js & forms we need to seperate that out to a single issue that cleans up the js dependencies in the forms, but we should do that in one patch, else its gonna be a logistical nightmare to make it work. Theres simply to many places that we need to clean up.

This patch removes the classes we can remove from core, without going down the rabbit hole of js dependency with forms

@todo create an issue with js prefix / data- attribute selectors for js functionality in core.
#2408473: Rewrite form.css inline with our CSS standards

Patch applies and works. No visual regressions. Back to RTBC then...

2 classes got deleted from core, that well take care at over in #2431671: [meta] Add in js- prefixed classes for separation of JS & CSS functionality

Looks good! Great job!

Node Teaser BEFORE

Node Teaser AFTER

Node BEFORE

Node AFTER

Node Edit Form BEFORE

Node Edit Form AFTER

We're removing lots of classes that people have become very accustomed to in this issue - all of these issues should share a single CR that list all of the classes removed and any added for js implementations.

@alex should we combine that with the cr for the form cleanup ? [#2452043]

@alex should we combine that with the cr for the form cleanup ? [#2452043]

changerecord added [#2452297]
setting back to rtbc ?

Back to Alex for feedback. Although...

+++ b/core/modules/field/src/Tests/EntityReference/EntityReferenceFormatterTest.php
@@ -177,6 +177,10 @@ public function testEntityFormatter() {
+    // Enable the Classy theme.
+    \Drupal::service('theme_handler')->install(['classy']);
+    $this->config('system.theme')->set('default', 'classy')->save();

This trend worries me a bit. It's adding noise to that test which has absolutely nothing to do with classy theme. And from the looks of it, this pattern is introduced in other tests as well.

What's the rationale for this? Did one of the other core committers recommend this approach?

How does the view-ui look in stark before and after this patch?

Also re #34 this means that the test has some assertions for classes removed by this patch. Which hints that these things need to be manually tested in stark to make sure they still work and are usable.

Putting back to needs work to ensure that (a) it is really necessary to have the tests depend on classy (b) that the necessary manual testing has been carried out and evidence posted to this issue.

[EDIT: to make sense]

@webchick the rationale is when a test is not using classy but goes to stark for the test.

It looks like all the js- prefix needing for this one has been done and it is free to work on.

The last patch was very, very old. So I tried to manually reapply the changes. It looked a few more classes had been made safe to remove, so I did my best guesses with some grepping. Some JS and tests might still need to be updated that have both js-form-required and form-required as part of the efforts to make the js version of the class. So there will probably be initial errors that can help find those problems.

This should be looked at carefully in case some of the classes are still needed.

Patch applies and works. No visual regressions.

This is missing the removal from feed-icon.

Looks like I gave feedback in 2015 :)

Fixing tag

Re-created patch from comment #39, considered comment #41. Patch is getting applied for 8.8.x upto 9.1.x.
Here adding before/after screenshot for the patch is not going to work, because patch has changes related to system module templates. But by default seven and bartik is picking classy theme templates instead of system module templates which are in patch file. Though i am adding screenshot as tagged for Screenshot.

Node Before

Node After

Node edit before

Node edit after