Allow defaulting toolbar tray to vertical orientation with configuration

This module is a backport of D8 core. I think you need to get the feature in D8 core first.

I understand that to have this merged I need to do this in D8 first. However, I thought I'd throw in the patch here anyway. This patch works with 7.x-1.x-dev.

Moving for decision making to D8. Please move back once done or just close if we do not like to implement this at all.

The reason is that a lot of people don't want to make multiple page requests to get somewhere, especially on mobile.

This is exactly what D8 already does.

Are you basically asking to do this always? Having used this myself for over a year, I personally think that that would make sense. But only for the "admin menu" toolbar tray, not for the other toolbar trays (e.g. shortcuts & user).

We already made the decision in #1137920: Fix toolbar on small screen sizes and redesign toolbar for desktop. We decided for horizontal. The opinions on preferences around this are probably split 50/50. We made the decision to go for horizontal, I see no reason to revisit that decision.

Regarding vertical/horizontal orientation. I'd interpreted the designs to indicate that the horizontal orientation is the default. On small screens, the orientation will switch to vertical. That breakpoint will be configurable.

If a user pegs the orientation to vertical for a tray (they will all -- administration menu, shortcuts, user actions -- be peggable, potentially, at least in the code), then the tray will remain vertical across all screen sizes.

If the opinions are split 50/50, wouldn't it be logical to allow site admins decide what should be the default layout. So far each client I showed this toolbar to asks to have it in vertical layout and that's the override I have to do and maintain for multiple sites.

I haven't looked into the module code yet, but I think it should be possible to move that setting into a variable, rather than having it hardcoded.

What do you guys think?

#5 It works fine!

Retitling to that scope and moving to 8.2.x where features go. Thanks!

Here is a patch that adds configuration form for Toolbar module that allows to set a default orientation - vertical or horizontal. I've tested it myself and seems to be working fine.

I must tell that JS logic probably needs to be refactored. It's pretty confusing that a lot of logic is tied to VerticalLock parameter. I think it should be more generic and rely on user selected orientation. If user hasn't selected anything, then it can fallback to a default setting.

Seems like tests failed in the unrelated module. I've run tests in my local environment and they passed successfully. Marking for re-testing.

I wanted to bring this to attention as I have a number of requests to have Toolbar with vertical orientation by default on both Drupal 7 and 8. As I understand before it gets to Drupal 7 it needs to be approved for 8 first. Can anyone review the above patch? Thanks!

@temkin: The Toolbar in Drupal 7 and 8 are vastly different. If you're referring to the D7 backport of the D8 toolbar, that's https://www.drupal.org/project/navbar, and that can happen any time.

OK, thanks. I was under the impression that it needs to be implemented for D8 first and then backported to D7. Probably because of the comment #6. If that's not the case, I'll open a ticket in Navbar's module issue queue and submit a patch there. We can keep this issue specifically to D8.

Any chance it can get reviewed?

Toolbar module has gone through changes since patch from #14 was submitted.

Some bits and pieces of code have moved around and portions of what previously was residing in toolbar.js now lives in a file called toolbar.menu.js

Would it be possible to move this into its own module and fix it so that it woks with the latest version?
Or, add a configuration to the core to give administrators the choice?

Hi, I just upgraded the patch from #14 for 8.5.x
But is not working for me

Hi, I just add the real patch from #14 for 8.5.x

Admin path admin ../config/user-interface/toolbar

Patch from #29 works for me on a fresh Drupal 8.7.2

Re-rolled the #29 patch because it's failed to apply on 8.8.x branch.

Our company made a new design for the toolbar. If you would like to check it:
https://www.drupal.org/project/seeds_toolbar
it's not perfect, but it is vertical.

#29 works for me. Make sure you clear all caches.

#33 works for me.

Needs work b/c:

1. No longer applies to 9.3.x
2. Needs a summary.

There’s a pile of issues trying to add toolbar settings. Eg

#2464193: Provide configuration options for toolbar menu

Tried to add that as related but I’m on my phone and it’s not working.

Point is: if it seems weird in here to add a whole new settings form for 1 knob, we’ll have a lot of other knobs we could add to it soon. 😉

Thanks,
-Derek

Re-roll of the patch against 9.3.x & keep it in Needs Work as it needs issue summary update.

Trying to resolve CS issues.

Re-roll for 10.0.x

Please review.

Testbot can’t run the tests.