Migration Files for Drupal 7 Contact

I did a patch to enable user to import Drupal 7 Contact in Drupal 8 following the same logic applied in Drupal 6 migrations files.

Work on Drupal 7 is still a little quiet so thanks for making a start. This will require tests, there should be plenty of examples in core already.

Moving to the IMP issue queue.

See parent issue #2181257: [meta] Variables to config migration [d7] for instructions.

Self-assigning -- let's bring it home!

@-enzo-, that's just an expression :) The next step is to write a passing automated test for the d7_contact_category migration, and add it to the patch in #6.

Added a test of the migration.

I also made the d6_contact_category source plugin into a generic contact_category source, since it's identical between D6 and D7 and it seems sad-making to not reuse that code.

Moving into the core issue queue so testbot will put the patch through its paces.

Re-upping the patch so testbot will (hopefully) test it.

Fixed errors in the contact_category plugin's unit test.

Minor test cleanup.

Blocked by #2495755: Create MigrateDrupal7TestBase.

+++ b/core/modules/migrate_drupal/src/Tests/d7/MigrateContactCategoryTest.php
@@ -0,0 +1,62 @@
+/**
+ * Migrate contact categories to contact.form.*.yml.
+ *
+ * @group migrate_drupal 7.x
+ * @dumpFile d7/Contact.php
+ * @migration d7_contact_category
+ */
+class MigrateContactCategoryTest extends MigrateDrupal7TestBase {

Is it intended to lose d6 test coverage?

Yeah that doesn't seem right.

What? There are two distinct tests of this migration: src/Tests/d6/MigrateContactCategoryTest.php and src/Tests/d7/MigrateContactCategoryTest.php. The former one is already in HEAD, though, so this patch adds the latter one.

Ah right, the diff was confusing, bit clearer once I actually applied it. I checked the D7 contact module and the fields are the same so I think this is good apart from a few small bits:

1. +++ b/core/modules/migrate_drupal/src/Tests/d7/MigrateContactCategoryTest.php
   @@ -0,0 +1,62 @@
   +  protected function assertEntity($id, $expected_label, array $expected_recipients, $expected_reply, $expected_weight) {
   

   Missing function doc.

2. +++ b/core/modules/migrate_drupal/src/Tests/d7/MigrateContactCategoryTest.php
   @@ -0,0 +1,62 @@
   +    $this->assertEqual($expected_reply, $entity->getReply());
   

   Why is this assertEqual when surrounded by assertIdentical's?

3. +++ b/core/modules/migrate_drupal/tests/src/Unit/source/ContactCategoryTest.php
   @@ -0,0 +1,74 @@
   +      'plugin' => 'd6_contact_category',
   

   This is contact_category now?

Fixed. Regarding #3 -- yes, I've renamed the plugin since the functionality is identical.

Re-rolled and merged #2353697: Variable to config: contact.settings [d7].

Whoops.

Re-rolling again.

Nearly finished rerolling but too late to continue.

Reroll

No interdiff due to changes in Variable.php

This should fix d7/MigrateContactSettingsTest but not the other errors. And it is too late to continue.

Putting the schema in the correct file definitely helps.

Looks like it was some overzealous editing.

A few fixes...

@mikeryan tells me that the failures in #59 have to do with the beta update path. So this patch is an experiment to see if adding an update function to Contact will fix the failures...

I meant to mark this unassigned after doing a reroll 3 weeks ago.

Another experiment.

Yet another experiment, suggested by @gábor-hojtsy -- trying to see if calling save(TRUE) in the update function will avoid these maddening schema errors.

+++ b/core/modules/contact/contact.install
@@ -0,0 +1,38 @@
+function contact_update_8001() {

Surely we don't provide update paths for migrations just yet?

As to the schema errors, could it be possible migrate isn'e enabled?

Re-rolled and removed the update path hook.

Postponing on #2569469: [Policy, no patch] No need to provide an upgrade path for Migrations and potentially #2569605: Remove migrations from update path test fixtures, since they need to be resolved before these tests will pass.

Nuh-uh.

Unblocked!

Re-rolled.

I'm fixin' to fix them test failures...

Applied and looked at it with git diff -M and mostly moves. New tests look good. Lets do it.

Committed and pushed to 8.0.x. Thanks!