Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

Status: Active » Needs review
FileSize
973 bytes

Patch.

andypost’s picture

seems there's no tests...

yched’s picture

yched’s picture

Side note: #2368349: Entity view and form display configuration schemas are too verbose / key ones missing adds a missing config schema for the current *field* setting.
If it gets committed first, the patch here will need to be updated to change the config schema accordingly (-> storage setting)

The last submitted patch, 3: 2376689-Integer_size-3-test-only.patch, failed testing.

The last submitted patch, 3: 2376689-Integer_size-3-test-only.patch, failed testing.

yched’s picture

Side note: It's just the "test only" patch that failed, as it should.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Sure, that's why I call re-test
PS: ContainerAwareEventDispatcherTest seems a bot flux that we see whole day

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
yched’s picture

Status: Needs work » Needs review
FileSize
3.62 KB
1.13 KB

Actually, #2368349: Entity view and form display configuration schemas are too verbose / key ones missing landed, so as mentioned in #4, we now also need to update the config schema.

[edit: heh, crosspost]

Status: Needs review » Needs work

The last submitted patch, 11: 2376689-Integer_size-10.patch, failed testing.

yched’s picture

Status: Needs work » Needs review
FileSize
3.2 KB
735 bytes

Bleh. Never mind #10, something weird happened in the copy/paste.

Patch with config schema change, and interdiff with #3
(also, using a diff algorithm that better reflects the actual change)

Status: Needs review » Needs work

The last submitted patch, 13: 2376689-Integer_size-13.patch, failed testing.

yched’s picture

Status: Needs work » Needs review
FileSize
3.65 KB
481 bytes

"SchemaIncompleteException: Schema errors for field.storage.entity_test.h7quxlds with the following errors: field.storage.entity_test.h7quxlds:settings.unsigned missing schema"
Weird - 'unsigned' is indeed missing from the schema (#2370305: Refactor field type configuration schemas for DX, easier to find errors is fixing that), but that doesn't cause an exception in NumberItemTest on my setup.

Well, adding it here as well if that's what it takes to make the testbot happy - this patch and #2370305: Refactor field type configuration schemas for DX, easier to find errors will conflict anyway.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to go

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed d3a7d13 and pushed to 8.0.x. Thanks!

  • alexpott committed d3a7d13 on 8.0.x
    Issue #2376689 by yched: IntegerItem 'size' setting should be a storage...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.