Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It's used for the schema, so it cannot vary by bundle...
Comment | File | Size | Author |
---|---|---|---|
#15 | interdiff.txt | 481 bytes | yched |
#15 | 2376689-Integer_size-15.patch | 3.65 KB | yched |
#13 | interdiff-3-13.txt | 735 bytes | yched |
#13 | 2376689-Integer_size-13.patch | 3.2 KB | yched |
#11 | interdiff.txt | 1.13 KB | yched |
Comments
Comment #1
yched CreditAttribution: yched commentedPatch.
Comment #2
andypostseems there's no tests...
Comment #3
yched CreditAttribution: yched commentedTest added.
Comment #4
yched CreditAttribution: yched commentedSide note: #2368349: Entity view and form display configuration schemas are too verbose / key ones missing adds a missing config schema for the current *field* setting.
If it gets committed first, the patch here will need to be updated to change the config schema accordingly (-> storage setting)
Comment #8
yched CreditAttribution: yched commentedSide note: It's just the "test only" patch that failed, as it should.
Comment #9
andypostSure, that's why I call re-test
PS:
ContainerAwareEventDispatcherTest
seems a bot flux that we see whole dayComment #10
alexpott#2368349: Entity view and form display configuration schemas are too verbose / key ones missing got in
Comment #11
yched CreditAttribution: yched commentedActually, #2368349: Entity view and form display configuration schemas are too verbose / key ones missing landed, so as mentioned in #4, we now also need to update the config schema.
[edit: heh, crosspost]
Comment #13
yched CreditAttribution: yched commentedBleh. Never mind #10, something weird happened in the copy/paste.
Patch with config schema change, and interdiff with #3
(also, using a diff algorithm that better reflects the actual change)
Comment #15
yched CreditAttribution: yched commented"SchemaIncompleteException: Schema errors for field.storage.entity_test.h7quxlds with the following errors: field.storage.entity_test.h7quxlds:settings.unsigned missing schema"
Weird - 'unsigned' is indeed missing from the schema (#2370305: Refactor field type configuration schemas for DX, easier to find errors is fixing that), but that doesn't cause an exception in NumberItemTest on my setup.
Well, adding it here as well if that's what it takes to make the testbot happy - this patch and #2370305: Refactor field type configuration schemas for DX, easier to find errors will conflict anyway.
Comment #16
andypostLooks good to go
Comment #17
alexpottThis issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed d3a7d13 and pushed to 8.0.x. Thanks!