Replace request_uri() with $request->getRequestUri()

I am working on this now...

Firstly- This is a first iteration. One unit test is failing and I am open to other ways forward.

There are 2 highly specialize calls to request_uri(TRUE), both called before the container and the request stack are available.
I have chosen to simplify the logic in request_uri for those function calls and place them in a new function request_uri_without_query_string().

I think that is an acceptable compromise, but hey that needs review.

Second - The following objects expect extra parameter in their constructors.

core/modules/locale/src/LocaleLookup.php - now requires a $request_uri string
core/modules/locale/src/LocaleTranslation.php - now requires a RequestStack object

This at first may look funny... I have followed the Law of Demeter, LocaleLookup only uses a string $request_uri and so I did not want to pass in a RequestStack object just so it could "reach through the parameter" to get what is actually wanted.

Thirdly

this from LocaleLookup.php

  /**
   * Wraps request_uri().
   */
  protected function requestUri($omit_query_string = FALSE) {
    return request_uri($omit_query_string);
  }

So this class was providing it own version of a wrapper used only once .. in short it can now be rationalized away..

Lastly @dawehner, can I confirm what I think you are thinking....

So the line is at this stage of the release cycle is :-

Change to core/modules/locale/locale.services.yml are a minor API change with limited impact to the rest of the system or contrib and are therefore acceptable?

I will try and finish this off tonight...

I have backouted out 85% of my changes.

LocaleLocaleLookupTest is failing a circular dependency test.

I have this quote from the constructor of \Drupal\early_translation_test\Auth

    // Authentication providers are called early during in the bootstrap.
    // Getting the user storage used to result in a circular reference since
    // translation involves a call to \Drupal\locale\LocaleLookup that tries to
    // get the user roles.
    // @see https://drupal.org/node/2241461

So using similar arguments a Request cannot be injected into LocaleLookup because
of the whole bootstrap thing... Ah so you live and learn :)

Also, request_uri_without_query_string() has been reverted back to request_uri()
I was being too clever and it doesn't work in the general case.

Other test are still failing ... but I will look more soon.

( The interdiff is not helpful in this instance and anyway the patch is small. )

Trivial fixup of DblogTest

A) Corrected mistake in annotation.
B) Removed function making a single called to another function. ( And the function overriding it for testing. )

Looking at failing test, which is due to this new call to getRequestUri()
in FormBuilder::prepareForm()

    // Only update the action if it is not already set.
    if (!isset($form['#action'])) {
      $form['#action'] = $this->requestStack->getCurrentRequest()->getRequestUri();
    }

$form['#action'] is set to "/batch?id=6&op=do_nojs&op=do"

I will have more time to look at this on Sunday

Working on this issue now.

re-roll

Rerrol patch based on #8 because y newed versions didnt appeared some changes.

It works for me.

Sorry for changing the status, it was a mistake.

@keopx Thanks for working on this!

Some remarks.

1. +++ b/core/includes/bootstrap.inc
   @@ -598,6 +598,12 @@ function drupal_validate_utf8($text) {
   + * NB This function is intended for limited use, in cases before the $container
   

   Does NB mean nota bene? Should be clarified. It is not common to use abbreviations in code comments.

2. +++ b/core/includes/bootstrap.inc
   @@ -598,6 +598,12 @@ function drupal_validate_utf8($text) {
   + * is available. Use $request->getRequestUri() whereever possible.
   

   Whereever typo, should be wherever.

3. +++ b/core/lib/Drupal/Core/DrupalKernel.php
   @@ -866,10 +866,10 @@ protected function initializeRequestGlobals(Request $request) {
   +        // $request->getRequestUri() returns a URI with the script name, resulting in
   
   +++ b/core/lib/Drupal/Core/Form/FormBuilder.php
   @@ -301,7 +301,7 @@ public function rebuildForm($form_id, FormStateInterface &$form_state, $old_form
   +    // #action defaults to $request->getRequestUri(), but in case of Ajax and other partial
   

   These comment lines exceed 80 chars. We need to re-wrap them.

I've addressed remarks in #36.

I've removed the NB comment and wondered if it should be instead tagged as deprecated?

@dawehner This issue should be closed now right and marked as duplicate?

Issue #2426489: Remove request_uri() was created after this issue but had progressed to RTBC before this issue was noticed.