Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Beta phase evaluation
Issue category | Bug because file field default values cannot be deployed, and deploying a reference to a serial ID that may or may not exist or be the same entity (as in HEAD) can result in errors and unexpected behavior. |
---|---|
Issue priority | Not critical because default file field values are not a sufficient reason to hold up the release. Major because the bug breaks the principles of the configuration system, makes file field deployments unreliable, and could introduce data integrity problems for entities having a file field with a default value. |
Prioritized changes | The main goal of this issue is fixing a bug, so it is a prioritized change for the beta phase. |
Disruption | Minor disruption for existing sites because it changes the data model for existing file fields (and therefore tagged 'D8 upgrade path'). |
Proposed resolution
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#17 | interdiff-2357801-14-17.txt | 708 bytes | amitgoyal |
#17 | 2357801-17.patch | 25.23 KB | amitgoyal |
#14 | 2357801-14.patch | 25.23 KB | dawehner |
#14 | interdiff.txt | 4.16 KB | dawehner |
#12 | 2357801-12.patch | 21.07 KB | dawehner |
Comments
Comment #1
alexpottComment #2
larowlanSure we solved this for term reference defaults already so perhaps could adapt that? But regardless - love it.
Comment #3
xjmComment #4
xjmComment #5
xjmI guess filefield default values being broken on deployment would not hold up release. (The views issue is definitely critical though.)
Comment #6
xjmComment #7
xjmComment #8
xjmComment #9
dawehnerWorked a bit on it.
Comment #11
catchIf this is anywhere near RTBC by the time we get to 0 upgrade path blockers, this is the kind of issue I'd rather see in before rather than after we start supporting 8-8 updates (so that we don't have to write a hook_update_N() here).
Comment #12
dawehnerMaybe this is enough already.
Comment #14
dawehnerLet's fix them.
Comment #15
jibranLooks awesome so RTBC.
Comment #16
catchThis should be
$original_uuid
. Minor but it looked like a logic error at first glance then realised just variable name hadn't been updated.Won't this be more expensive? Not sure about calculating this in the widget, although could be a follow-up, presumably we have similar issues elsewhere.
Comment #17
amitgoyal CreditAttribution: amitgoyal commented1) Variable name
$original_fid
has been changed to$original_uuid
.2) May be a follow-up.
Comment #18
dawehnerI'd argue that this is "just" for the edit UI, so even requiring the conversion is a bit sad, its not part of the critical path.
Comment #19
catchThanks for the variable rename and makes sense on edit UI given it's the widget..
Committed/pushed to 8.0.x, thanks!