(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/update/templates/update-last-check.html.twig
core/modules/update/templates/update-project-status.html.twig
core/modules/update/templates/update-report.html.twig
core/modules/update/templates/update-version.html.twig

CommentFileSizeAuthor
#5 copy_update_templates-2349769-5.patch13.96 KBcilefen
#5 interdiff-2-5.txt15.21 KBcilefen
#2 copy_update_templates-2349769-2.patch12.29 KBcilefen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Assigned: Unassigned » cilefen
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Assigned: cilefen » Unassigned
Status: Active » Needs review
FileSize
copy_update_templates-2349769-2.patch12.29 KB

I think we want to move all of core/modules/update/css/update.admin.css to Seven.

cilefen’s picture

cilefen CreditAttribution: cilefen commented 
  1. +++ b/core/modules/update/templates/update-project-status.html.twig
@@ -29,25 +29,16 @@
-{%
-  set status_classes = [
-    project.status == constant('UPDATE_NOT_SECURE') ? 'security-error',
-    project.status == constant('UPDATE_REVOKED') ? 'revoked',
-    project.status == constant('UPDATE_NOT_SUPPORTED') ? 'not-supported',
-    project.status == constant('UPDATE_NOT_CURRENT') ? 'not-current',
-    project.status == constant('UPDATE_CURRENT') ? 'current',
-  ]
-%}

    These classes may be considered essential to the module's function. 

  2. +++ b/core/modules/update/templates/update-project-status.html.twig
@@ -55,46 +46,39 @@
-{%
-  set extra_classes = [
-    project.status == constant('UPDATE_NOT_SECURE') ? 'project-not-secure',
-    project.status == constant('UPDATE_REVOKED') ? 'project-revoked',
-    project.status == constant('UPDATE_NOT_SUPPORTED') ? 'project-not-supported',
-  ]
-%}

    Also, these may be considered essential to the module's function. But since in this case this module is admin-only, it may be fine if they exist in Seven only.

Status: Needs review » Needs work

The last submitted patch, 2: copy_update_templates-2349769-2.patch, failed testing.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs work » Needs review
FileSize
interdiff-2-5.txt15.21 KB
copy_update_templates-2349769-5.patch13.96 KB

I moved the templates from class/templates/update to classy/templates and edited a test that referenced the class names.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez commented

Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

@davidhernandez - Thank for checking on the JS situation.

The update templates seem to work in Stark, but I should not be the last word. To anyone else testing, the update module paths are:

  • path: '/admin/reports/updates/settings'
  • path: '/admin/reports/updates'
  • path: '/admin/reports/updates/check'
  • path: '/admin/reports/updates/install'
  • path: '/admin/reports/updates/update'
  • path: '/admin/modules/install'
  • path: '/admin/modules/update'
  • path: '/admin/theme/install'
  • path: '/admin/theme/update'
  • path: '/admin/update/ready'

lauriii queued 5: copy_update_templates-2349769-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: copy_update_templates-2349769-5.patch, failed testing.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs work » Postponed

See https://www.drupal.org/node/2348543#comment-9564823

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii as a volunteer and at Druid commented
Component: theme system » Classy theme
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Version: 8.0.x-dev » 9.x-dev

Automated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.x-dev » 8.3.x-dev
Priority: Normal » Minor

Moving back to 8.3.x and minor per #2349661: Copy config_translation templates to Classy.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Project: Drupal core » Classy
Version: 10.1.x-dev » 1.0.x-dev
Component: Classy theme » Code

Asked in #frontend and andy-blum replied that this should move to the contrib project.