(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/language/templates/language-negotiation-configure-form.html.twig

CommentFileSizeAuthor
#1 copy_language_templates-2349707-1.patch1.25 KBmortendk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mortendk’s picture

mortendk CreditAttribution: mortendk commented
Status: Active » Needs review
Issue tags: +cssbanana
FileSize
copy_language_templates-2349707-1.patch1.25 KB
mortendk’s picture

mortendk CreditAttribution: mortendk commented
Issue tags: +drupalhagen
Xen’s picture

Xen CreditAttribution: Xen commented
Assigned: Unassigned » Xen
Xen’s picture

Xen CreditAttribution: Xen commented
Assigned: Xen » Unassigned
Status: Needs review » Reviewed & tested by the community

Is properly picked up in Bartik.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
Status: Reviewed & tested by the community » Needs work

Dunno whats wrong but the file is not created to classy

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
Status: Needs work » Reviewed & tested by the community

Sorry for being headless lauri. Have to use git apply instead

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/language/templates/language-negotiation-configure-form.html.twig
@@ -21,16 +21,9 @@
-      'table-language-group',

This is used in language.admin.js not sure we should be moving this to classy without a better plan.

Xen’s picture

Xen CreditAttribution: Xen commented
Assigned: Unassigned » Xen

Missed that.

Then it should be prefixed by js- and applied differently... I'll look into it.

Xen’s picture

Xen CreditAttribution: Xen commented

Well, seems that my D8-fu is not quite enough for the language-negotiation-configure-form...

In case anyone else want to give it a stab: The JS don't come into play until there's more than one negotiation type to be configured, which isn't the case by default. It's easy to do by running drush config-edit language.types and adding language_content to configurable. Secondly, one needs to be *not* locked, which isn't the case either per default. And I don't know when that'll be the case, so I ended up hacking it in for testing.

You'd think when you'd gotten all that in line, it would be a simple matter too add a class to the form render array and be done with it, but the template loops over language_types which isn't form elements, so adding a class attribute isn't as strait-forward as it could be.

Maybe some of the theming/template/form bigshots should take a look at this form. As it is, getting the js class in the proper place would be hacky, and I can't really spot the proper way to do it.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez commented
Status: Needs work » Postponed

Postponing for now. See #2348543: [meta] Consensus Banana Phase 2, transition templates to the starterkit theme for updates.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii as a volunteer and at Druid commented
Component: theme system » Classy theme
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Version: 8.0.x-dev » 9.x-dev

Automated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.x-dev » 8.3.x-dev
Priority: Normal » Minor

Moving back to 8.3.x and minor per #2349661: Copy config_translation templates to Classy.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Project: Drupal core » Classy
Version: 10.1.x-dev » 1.0.x-dev
Component: Classy theme » Code
Issue tags: -

Asked in #frontend and andy-blum replied that this should move to the contrib project.