Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
ContentEntityDatabaseStorage
is a misleading name, since the only supported DBMSes are SQL-based ones. NoSQL storage implementations would need to extend ContentEntityStorageBase
(or start from scratch).
Proposed resolution
Since we already have a SqlEntityStorageInterface
, for consistency we should rename ContentEntityDatabaseStorage
to SqlContentEntityStorage
.
Remaining tasks
- Agree on a solution
- Code it
- Review it
User interface changes
none
API changes
Renamed ContentEntityDatabaseStorage
to SqlContentEntityStorage
.
Comment | File | Size | Author |
---|---|---|---|
#20 | entity-rename_cedb-2330091-20.patch | 45.47 KB | plach |
#20 | entity-rename_cedb-2330091-20.interdiff.txt | 1.34 KB | plach |
#18 | entity-rename_cedb-2330091-18.patch | 44.84 KB | plach |
#18 | entity-rename_cedb-2330091-18.interdiff.txt | 7.74 KB | plach |
#18 | entity-rename_cedb-2330091-13.interdiff.txt | 40.02 KB | plach |
Comments
Comment #1
plachFirst attempt
Comment #3
plachwow
Comment #5
plachBogus patch
Comment #7
yched CreditAttribution: yched commentedOh yes please :-)
Comment #8
plachForgot to rename the unit test class file.
Comment #9
effulgentsia CreditAttribution: effulgentsia commentedLooks good.
Comment #10
plachMaybe we should move the class to the
Drupal\Core\Entity\Sql
namespace while we are at it?Comment #11
effulgentsia CreditAttribution: effulgentsia commentedRe #10: +1 from me. What do others think?
Comment #12
BerdirThe interface is already on there, makes sense to me.
What do we want to do with EntityDatabaseStorage now? It's unused and untested, so maybe we should just remove it instead of bothering to rename it?
Comment #13
plachRemoved
EntityDatabaseStorage
and moved content entity storage and schema handler to the Sql namespace.Comment #15
BerdirLooks like there's still one test entity type using that storage. Let's clean that up in a separate issue, sorry for the noise.
Comment #16
BerdirDouble-post. More noise.
Comment #17
BerdirOpened #2332577: Remove EntityDatabaseStorage for that, might need some more discussion about the EntityApiInfoTest, so i think it's better to keep that separate.
Comment #18
plachReverted
EntityDatabaseStorage
changes. Attaching also the interdiff that I forgot in #13.Comment #20
plachFixed unit tests
Comment #21
BerdirOk, good to go. EntityDatabaseStorage is also already RTBC, but it's still better to keep it separate I think.
Comment #22
catchCommitted/pushed to 8.0.x, thanks!