Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Move classes out of the preprocess functions and into the Twig templates. Use the addClass() attribute method to add classes in the template. Use the clean_class filter to filter class names, if necessary. Maintain all existing functionality and ensure all existing class names are still in the markup, even ones that are inherited.
See the following issues for more detailed examples:
#2217731: Move field classes out of preprocess and into templates
#2254153: Move node classes out of preprocess and into templates
See this change record for information about using the addClass() method:
https://www.drupal.org/node/2315471
See this change record for more information about the phase 1 process of moving class from preprocess to templates:
https://www.drupal.org/node/2325067
Preprocess Functions Modified
template_preprocess_status_messages
template_preprocess_feed_icon
template_preprocess_field_multiple_value_form
Twig Templates Modified
status-messages.html.twig
feed-icon.html.twig
field-multiple-value-form.html.twig
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2329853-3.patch | 1.59 KB | star-szr |
Comments
Comment #1
davidhernandezComment #2
star-szrNot sure there's much we can do with template_preprocess_field_multiple_value_form() because it's within a #type table, but I'll work on a patch for the other two.
Comment #3
star-szrHere's a start.
Comment #4
lauriiiTested this and classes still seems to be there how supposed to. Code seems to be what it should be and all the possible classes have been removed from preprocesses.
Comment #5
catchWas a bit confused because
template_preprocess_status_messagesdoesn't add classes and is not touched by the patch. So the messages template change is just bringing it up to standards.Committed/pushed to 8.0.x, thanks!
Comment #7
star-szrYou're right, that wasn't really following the issue title, just aiming for consistency. Thanks @catch!