statistics.php is not platform directory separator aware [#2327953]

I have encountered a new issue in statistics.php file.

My statistics counters do not increment. I am running on IIS and the define at the top

define('DRUPAL_ROOT', substr($_SERVER['SCRIPT_FILENAME'], 0, strpos($_SERVER['SCRIPT_FILENAME'], '/modules/statistics/statistics.php')));

is not platform directory separator aware.

It should be something like:

PHP_OS == "Windows" || PHP_OS == "WINNT" ?
  define('DRUPAL_ROOT', substr($_SERVER['SCRIPT_FILENAME'], 0, strpos($_SERVER['SCRIPT_FILENAME'], '\\modules\\statistics\\statistics.php'))) :
  define('DRUPAL_ROOT', substr($_SERVER['SCRIPT_FILENAME'], 0, strpos($_SERVER['SCRIPT_FILENAME'], '/modules/statistics/statistics.php')))

Comment	File	Size	Author
#3	2327953-ajax-stats-not-working-IIS.patch	667 bytes	david_garcia
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

David_Rothstein CreditAttribution: David_Rothstein commented 10 February 2015 at 17:52

Version:	7.31	» 7.x-dev
Status:	Active	» Needs review

There's a patch from @david_garcia based on an idea from @mikeytown2 at #1209532-247: Count node views via AJAX in the statistics module that fixes this in a way that shouldn't involve checking the operating system - let's review that.

Comment #2

fgm

French

Paris, France

CreditAttribution: fgm commented 11 February 2015 at 12:49

Why not use the standard DIRECTORY_SEPARATOR constant instead of doing manual replacements with '/' and '\\' like this ?

Comment #3

david_garcia CreditAttribution: david_garcia commented 27 March 2015 at 19:53

File	Size
2327953-ajax-stats-not-working-IIS.patch	667 bytes

Comment #4

david_garcia CreditAttribution: david_garcia commented 27 March 2015 at 19:55

@fgm Yes we could use the DIRECTORY_SEPARATOR, but we need a new patch then.

Comment #5

Timothy.Siford CreditAttribution: Timothy.Siford as a volunteer commented 31 August 2015 at 13:29

Version:	7.x-dev	» 7.39
Status:	Needs review	» Reviewed & tested by the community

+1. Tested on Drupal 7.39, IIS, SQL Server 2014, PHP 5.6.0.

Comment #6

cilefen CreditAttribution: cilefen commented 2 September 2015 at 19:47

Version:	7.39	» 7.x-dev
Status:	Reviewed & tested by the community	» Needs work

This needs work for #4 or a decision not to go with DIRECTORY_SEPARATOR.

Comment #7

david_garcia CreditAttribution: david_garcia commented 18 January 2016 at 23:25

Why not use the standard DIRECTORY_SEPARATOR constant instead of doing manual replacements with '/' and '\\' like this

Assuming that you don't know what the input will be like, this is much more robust, because it normalizes whatever results from calling realpath($_SERVER['SCRIPT_FILENAME']).

So I vote that we go with the current no brain melter patch unchanged.