Problem/Motivation

DiffFormatter component uses   for indenting/presentation.
Twig auto-escape double encodes this to  .

Proposed resolution

Marke   safe.

Remaining tasks

Review

User interface changes

None

API changes

None

NB: There is no Diff component - so using config system for now

CommentFileSizeAuthor
#12 2314513-10-reroll.patch718 bytesjoelpittet
#10 2314513-10.patch717 bytesjoelpittet
diff-formatter-dbl-esc.pass_.patch1.44 KBlarowlan
diff-formatter-dbl-esc.fail_.patch849 byteslarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review

The last submitted patch, diff-formatter-dbl-esc.fail_.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Thanks.

chx’s picture

chx CreditAttribution: chx commented
Status: Reviewed & tested by the community » Closed (duplicate)

#2280963: Refactor use of SafeMarkup in HWLDFWordAccumulator note: we are not adding more SafeMarkup::set() calls to core. This is not the way. We remove as much as we can instead.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue tags: +SafeMarkup
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Related issues: +#2280963: Refactor use of SafeMarkup in HWLDFWordAccumulator

Adding issue this is duplicate of as Related.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Title: DiffFormatter double escapes   » Add test coverage for DiffFormatter not double escaping  
Category: Bug report » Task
Status: Closed (duplicate) » Needs work

This was marked as a duplicate of #2280963: Refactor use of SafeMarkup in HWLDFWordAccumulator, which is now fixed, but did not add test coverage. Let's repurpose this issue to just add the test coverage from this patch?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs work » Needs review
Issue tags: -SafeMarkup
FileSize
2314513-10.patch717 bytes

Here's the same patch but test only.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
FileSize
2314513-10-reroll.patch718 bytes

Reroll

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Issue tags: +test coverage
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

lol, three minors and counting. Let's get this in. ;)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed e439d23 to 8.4.x and ee8f13d to 8.3.x. Thanks!

Backported to 8.3.x cause it is just additional test coverage.

  • alexpott committed e439d23 on 8.4.x 
    Issue #2314513 by joelpittet, larowlan: Add test coverage for...

  • alexpott committed ee8f13d on 8.3.x 
    Issue #2314513 by joelpittet, larowlan: Add test coverage for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.