Problem/Motivation

I've been tinkering with previewing of terms and users in my spare time but hit some issues with rdf module which assumes that entities will always have an ID.
This will break Layout Builder previews too.

Proposed resolution

Make rdf module handle viewing user and term entities with no IDs

Remaining tasks

Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#42 interdiff_40-42.txt1.23 KBravi.shankar
#42 2314509-42.patch7.76 KBravi.shankar
#40 interdiff_38-40.txt538 bytesravi.shankar
#40 2314509-40.patch7.74 KBravi.shankar
#38 interdiff_35-38.txt2.39 KBakshay_d
#38 2314509-38.patch7.74 KBakshay_d
#36 interdiff-35_36.txt423 bytesAbhijith S
#36 2314509-36.patch7.44 KBAbhijith S
#35 2314509-35.patch7.73 KBajaypratapsingh
#32 interdiff-2314509-31_32.txt494 bytesGauravvvv
#32 2314509-32.patch7.38 KBGauravvvv
#31 2314509-31.patch7.69 KBkarishmaamin
#18 rdf-preview.18.patch7.25 KBlarowlan
#18 interdiff.txt1.41 KBlarowlan
#13 rdf-preview.13.patch7.47 KBlarowlan
#12 rdf-preview.5.patch154.43 KBlarowlan
#12 interdiff.txt1.2 KBlarowlan
#10 rdf-preview.4.patch7.46 KBlarowlan
#10 interdiff.txt437 byteslarowlan
#7 interdiff.txt607 byteslarowlan
#6 rdf-preview.3.patch7.53 KBlarowlan
#4 rdf-preview.2.patch7.2 KBlarowlan
rdf-preview.pass_.patch7.1 KBlarowlan
rdf-preview.fail_.patch2.1 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review

The last submitted patch, rdf-preview.fail_.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: Unassigned » scor
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
rdf-preview.2.patch7.2 KB

Status: Needs review » Needs work

The last submitted patch, 4: rdf-preview.2.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
rdf-preview.3.patch7.53 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
FileSize
interdiff.txt607 bytes

Status: Needs review » Needs work

The last submitted patch, 6: rdf-preview.3.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: scor » larowlan
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
interdiff.txt437 bytes
rdf-preview.4.patch7.46 KB

Status: Needs review » Needs work

The last submitted patch, 10: rdf-preview.4.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.2 KB
rdf-preview.5.patch154.43 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
FileSize
rdf-preview.13.patch7.47 KB

Borked re-roll

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: larowlan » scor

over to @scor to review

scor’s picture

scor CreditAttribution: scor commented

@larowlan could you describe how to reproduce this bug? can it only be triggered programmatically, or is there a way to reproduce in the UI?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Hi @scor, only programmatically, there's an example in the test. Basically if you call entity_view with an unsaved user or term

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
+++ b/core/modules/rdf/rdf.module
@@ -340,35 +342,41 @@ function rdf_preprocess_node(&$variables) {
+  catch (EntityMalformedException $e) {
+    // We log this exception and then continue.
+    watchdog_exception('rdf', $e);
+  }

Mh, are we really sure we should log it and not just check if ($account->isNew()) before?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
FileSize
interdiff.txt1.41 KB
rdf-preview.18.patch7.25 KB

Fixes #17

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs review » Needs work

Patch no longer applies.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Title: RDF module prevents viewing of unsaved users and terms (and therefore previewing) » RDF module prevents viewing of unsaved users
Issue summary: View changes
Issue tags: +Needs reroll, +Blocks-Layouts

This issue still exists for Users, but not for terms anymore

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
karishmaamin’s picture

karishmaamin CreditAttribution: karishmaamin at Specbee commented
Status: Needs work » Needs review
FileSize
2314509-31.patch7.69 KB

Re-rolled patch against 9.4.x

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at Srijan | A Material+ Company for Drupal India Association commented
FileSize
2314509-32.patch7.38 KB
interdiff-2314509-31_32.txt494 bytes

Re-rolled patch #31, Attached interdiff for same.

Status: Needs review » Needs work

The last submitted patch, 32: 2314509-32.patch, failed testing. View results

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ajaypratapsingh’s picture

ajaypratapsingh CreditAttribution: ajaypratapsingh at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
2314509-35.patch7.73 KB

Just rerolled patch #31 against drupal 9.4.x

Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented
FileSize
2314509-36.patch7.44 KB
interdiff-35_36.txt423 bytes

Fixed the custom command issue in patch #35.

Status: Needs review » Needs work

The last submitted patch, 36: 2314509-36.patch, failed testing. View results

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee for Drupal India Association commented
Version: 9.4.x-dev » 9.5.x-dev
Assigned: scor » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2314509-38.patch7.74 KB
interdiff_35-38.txt2.39 KB

Rerolled the patch and fixed the custom commands errors.
Please Review

Status: Needs review » Needs work

The last submitted patch, 38: 2314509-38.patch, failed testing. View results

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
2314509-40.patch7.74 KB
interdiff_38-40.txt538 bytes

Trying to fix failed tests of patch #38.

Status: Needs review » Needs work

The last submitted patch, 40: 2314509-40.patch, failed testing. View results

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
2314509-42.patch7.76 KB
interdiff_40-42.txt1.23 KB

Fixing failed tests of patch #40.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Project: Drupal core » Resource Description Framework (RDF)
Version: 9.5.x-dev » 2.x-dev
Component: rdf.module » Code

#28 claims this is still an issue so moving over to the new contrib module

RDF is moving out of core and into https://www.drupal.org/project/rdf moving there.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work