Problem/Motivation

For performance reasons,
in Menu/ViewsMenuLink::getTitle()

Proposed resolution

Get the translated value from the config without instantiating the view.

And/or for a non-multilingual site, get the title and description just from the plugin definition the way MenuLinkContent does to avoid loading the entity.

Remaining tasks

  • investigate if it is possible

User interface changes

No.

API changes

No?

CommentFileSizeAuthor
#9 2310379-9.patch3.04 KBpwolanin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

The easiest way would be probably to check whether config translation is enabled, or rather whether there is any dynamically altering of config in the wild.

johanv’s picture

johanv CreditAttribution: johanv commented
Issue tags: +Amsterdam2014

I will try to fix this.

johanv’s picture

johanv CreditAttribution: johanv commented
Issue tags: -Amsterdam2014

When I read this first, I thought this would be easy. It isn't :-) Probably because I am new to Drupal 8, so I still have to find my way in configuration, views menu links and translation.

Because I won't be able to fix this today, I will write down what I found out, maybe it is helpful for someone else.

Menu/ViewsMenuLink::getTitle() (which is in core/modules/views/src/Plugin/Menu/ViewsMenuLink.php) is called to render menu items generated by views. You can create one by creating a new view, display it on a page, and create a menu item for this page. ViewsMenuLink:getTitle will return the localized title of the view you created.

ViewsMenuLink implements MenuLinkInterface. So we will have to reimplement getTitle, so that it can return the localized title without having to instantiate the complete view. Sounds fair enough.

Now the issue suggest to get the translation from 'the config'. I am not sure yet which config is meant.

The other suggestion refers to MenuLinkContent. For 'MenuLinkContent', getTitle is implemented as follows:

public function getTitle() {
   return $this->get('title')->value;
 }

I am not sure how this translates to MenuLinkInterface.

Sorry I couldn't work this out. Maybe I'll look at it again some day, when I am getting more used to the Drupal 8 architecture.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Version: 8.0.x-dev » 8.2.x-dev

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

One related issue: #2716019: View titles in breadcrumb and metatag title don't get properly translated

pwolanin’s picture

pwolanin CreditAttribution: pwolanin as a volunteer and at SciShield commented

So, I think we just have to read the property out of the view (config entity)?

I assume that's translated, if needed when the config entity is loaded?

for the content view:

$view_entity = \Drupal::entityManager()->getStorage('view')->load('content');

$displays = $view_entity->get('display');

$title = $displays["page_1"]["display_options"]["menu"]["title"];
pwolanin’s picture

pwolanin CreditAttribution: pwolanin as a volunteer and at SciShield commented
Status: Active » Needs review
FileSize
2310379-9.patch3.04 KB

Roughly like this (need to test that config overrides and translations work right)

Status: Needs review » Needs work

The last submitted patch, 9: 2310379-9.patch, failed testing.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.