Follow-up to #2295737: Not all shipped configuration passes validation even with all modules enabled

Problem/Motivation

shortcut.set.default:links is not used.

Proposed resolution

Remove unused config element.

Remaining tasks

Identify reasons. Fix as much as possible. Add tests as appropriate.

User interface changes

None.

API changes

None.

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Active » Closed (duplicate)

Closing as duplicate of the parent issue because it cannot be resolved with tests without this being resolved there AFAIS. Please reopen if not :)

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Closed (duplicate) » Active

@Gábor Hojtsy, this is unused element that needs to be removed.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

How will #2295737: Not all shipped configuration passes validation even with all modules enabled pass without it being removed?

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented

Ok, I can see what do you mean now. However we can make #2295737: Not all shipped configuration passes validation even with all modules enabled to pass by replacing the schema of this element from 'sequence' to 'string' type. As this needs more cleanup than just config & schema removal.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Closed (duplicate)

Spoke with @Gábor Hojtsy on IRC. We don't need one more follow up to get this important change committed. Let's make it part of parent and get it in.