Columns used in an index must be before any BLOB/TEXT columns. Currently the data column is 2nd; I propose to make the data column last so that the memory table could be used for the cache_* tables.
http://www.mysqlperformanceblog.com/2011/09/06/dynamic-row-format-for-me...
http://www.percona.com/doc/percona-server/5.5/flexibility/improved_memor...
Comment | File | Size | Author |
---|---|---|---|
#15 | 2285423-15.patch | 1.1 KB | ravi.shankar |
#1 | drupal-2285423-1-data-column-last-cache-bin-D8.patch | 1.1 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedComment #2
Crell CreditAttribution: Crell commentedI do not see a downside.
Comment #3
alexpottLike it! But we should have a comment to explain why data being last is a good idea
Comment #4
sunHm. Instead of (or in addition to) a comment, I'd rather add a very quick unit test that asserts the expectation that 'data' comes last, so that this improvement is not mistakenly destroyed by someone else in the future.
Comment #5
mikeytown2 CreditAttribution: mikeytown2 commentedLooking at SchemaTest and I don't see a way to test the order in which the schema is defined inside of DatabaseBackend::schemaDefinition.
Comment #14
andypostComment #15
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedHere I have added reroll of patch #1 for Drupal-9.2.x.
Comment #16
sanjayk CreditAttribution: sanjayk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedMoving to Need Review.
Comment #17
alexpottDon't we need an update path here to re-order existing cache tables?
I think we need to drop the table column from all the tables and then add it back again. But there are number of complexities here:
Comment #22
smustgrave CreditAttribution: smustgrave at Mobomo commentedThis issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.
Tagging for tests
As mentioned in #17 this would need a path forward, some kind of update hook I imagine.
Tagging for subsystem review for their thoughts on this change also.