Install standard profile, go to admin/structure/contact/manage/feedback/fields and you get a wsod "Fatal error: Call to a member function getType() on a non-object in core/modules/comment/comment.module on line 951".

CommentFileSizeAuthor
#11 2285349-11-followup.patch1.76 KBeffulgentsia
#2 2285349-2.patch3.21 KBolli
#2 2285349-fail.patch2.46 KBolli
_comment_entity_uses_integer_id.patch767 bytesolli
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue tags: +Needs tests
olli’s picture

olli CreditAttribution: olli commented
Issue tags: -Needs tests
FileSize
2285349-fail.patch2.46 KB
2285349-2.patch3.21 KB

The last submitted patch, 2: 2285349-fail.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

Legend

chx’s picture

chx CreditAttribution: chx commented

Can we drop the comment entity destination from migrate following this?

olli’s picture

olli CreditAttribution: olli commented

Re #5: I don't see how this would affect migrate. Could you elaborate?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Hm. What are the circumstances under which an entity won't have an ID? That doesn't seem like a desirable trait to preserve?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Contact messages have no id

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

  • Commit 2da5085 on 8.x by Dries: 
    Issue #2285349 by olli: Fixed Fatal error: Call to a member function...
effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Status: Fixed » Needs review
FileSize
2285349-11-followup.patch1.76 KB

A little cleanup to function name and code comments.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Reviewed & tested by the community

Yep.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit accd351 on 8.x by webchick: 
    Issue #2285349 follow-up by effulgentsia: Cleanup to function name and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.