Move drupal_match_path in path.inc to a service

My 2c

1. +++ b/core/lib/Drupal/Core/Path/PathMatcher.php
   @@ -0,0 +1,69 @@
   +      // Convert path settings to a regular expression.
   +      // Therefore replace newlines with a logical or, /* with asterisks and the
   +      // <front> with the frontpage.
   

   Some spacing could be cleaned up here? Also sentence doesn't really make sense.

2. +++ b/core/lib/Drupal/Core/Path/PathMatcherInterface.php
   @@ -0,0 +1,28 @@
   + * Interface for URL path matchers.
   

   nitpick: I think this has to start with a verb, 'Provides an' maybe

3. +++ b/core/tests/Drupal/Tests/Core/Path/PathMatcherTest.php
   @@ -0,0 +1,84 @@
   +  /**
   +   * Test that standard paths works with multiple patterns.
   +   */
   +  public function testPathsMultiplePatterns() {
   +    $patterns = array('my/pass/page', 'my/pass/page2', 'foo');
   +    $this->assertTrue($this->pathMatcher->matchPath('my/pass/page', $patterns), 'The path my/pass/page matches.');
   +    $this->assertTrue($this->pathMatcher->matchPath('my/pass/page2', $patterns), 'The path my/pass/page2 matches.');
   +  }
   +
   +  /**
   +   * Test paths match against wildcards.
   +   */
   +  public function testWildcardPath() {
   +    $patterns = array('my/pass/*');
   +    $this->assertTrue($this->pathMatcher->matchPath('my/pass/page3', $patterns), 'The path my/pass/page3 matches.');
   +  }
   +
   +  /**
   +   * Test a missing path does not match.
   +   */
   +  public function testNoMatchPath() {
   +    $patterns = array('my/pass/page', 'my/pass/page2', 'foo');
   +    $this->assertFalse($this->pathMatcher->matchPath('my/pass/page4', $patterns), 'The path my/pass/page4 does not match.');
   +  }
   

   these lend themselves to a provider?

1. +++ b/core/lib/Drupal/Core/Path/PathMatcher.php
   @@ -0,0 +1,67 @@
   +  public function __construct(ConfigFactoryInterface $config_factory) {
   +    $this->frontPage = $config_factory->get('system.site')->get('page.front');
   +  }
   

   It would be great to not do anything in the constructor. Calling the config factory methods could deal with language overrides which could trigger the entity system and what not. This resulted in a couple of circular dependencies in the past, so we figure out that it is a bad pattern.

2. +++ b/core/lib/Drupal/Core/Path/PathMatcherInterface.php
   @@ -0,0 +1,28 @@
   +   * @param string[] $patterns
   

   Nice!

:(

Thank you

Why are we supporting arrays and strings as patterns and not only arrays?

@hass, open a feature request. This just moves the function to a method, we're not changing the expectations or internals.

It changes internals.

:-( i was happy about this array change... Just wished it will change consequently in all places of core... :-)

Looks good but needs a draft change notice:)

i liked the array version too, but lets do a straight conversion here and move the array change to a followup.

thanks @kim.pepper !

Sounds very good to me. Thx.

Looks green

Can we remove Drupal\system\Tests\Path\MatchPathTest - and ensure that all the test cases that covers are covered by the phpunit test.

Thank you. Back to RTBC.

We can now inject this into the new RequestPath condition

Everything in here looks good. @kim.pepper++

+++ /dev/null
@@ -1,131 +0,0 @@
-class MatchPathTest extends WebTestBase {

+++ b/core/tests/Drupal/Tests/Core/Path/PathMatcherTest.php
@@ -0,0 +1,176 @@
+class PathMatcherTest extends UnitTestCase {

Nice!

Committed 9b821cd and pushed to 8.x. Thanks!