Problem/Motivation

The feed icon on taxonomy term pages has been broken in HEAD awhile, linking to (e.g.)
taxonomy/term/taxonomy/term/1/feed
instead of
taxonomy/term/1/feed

Additionally, #1857256: Convert the taxonomy listing and feed at /taxonomy/term/%term to Views removes the broken feed icon.

Proposed resolution

Re-add the icon once #2251121: Support to add a feed icon on pages with parameters is fixed.

Remaining tasks

TBD

User interface changes

Feed icon returns!

API changes

None.

Postponed until

#2251121: Support to add a feed icon on pages with parameters

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm’s picture

Issue tags: +Needs tests
jibran’s picture

Title: [PP-1] Add the feed icon back to taxonomy/term/% pages » Add the feed icon back to taxonomy/term/% pages
Issue summary: View changes
Status: Postponed » Closed (duplicate)
Issue tags: -Needs tests

#2251121: Support to add a feed icon on pages with parameters got committed and feed url is /taxonomy/term/1/feed

olli’s picture

#2251121: Support to add a feed icon on pages with parameters didn't add feed icon back to the default taxonomy term view.

jibran’s picture

I'm confused. What do you mean? Was I wrong to close this as duplicate? The bug described in IS is not in the HEAD anymore.

olli’s picture

Status: Closed (duplicate) » Active

Not sure, but I think this issue is about adding the icon back to the page.

olli’s picture

Status: Active » Needs review
FileSize
763 bytes
2.47 KB

Here is the proposed resolution from IS.

olli’s picture

+++ b/core/modules/taxonomy/config/optional/views.view.taxonomy_term.yml
@@ -236,6 +239,15 @@ display:
+      link_display: page_1

Note that this is now in the default display. Not sure if it would be better to add it only for feed_1.

The last submitted patch, 6: 2251861-6-test.patch, failed testing.

jibran’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
110.82 KB
101.26 KB

I don't know why it was there when I test it in #2.
Any ways

HEAD

After the Patch

Thanks for the patch and fix @olli.

  1. +++ b/core/modules/taxonomy/config/optional/views.view.taxonomy_term.yml
    @@ -236,6 +239,15 @@ display:
    +      display_extenders: {  }
    
    @@ -265,6 +277,13 @@ display:
    +      display_extenders: {  }
    

    I don't like this craft but we can live with it.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2251861-6.patch, failed testing.

jibran’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
2.45 KB

Reroll

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 3559826 and pushed to 8.0.x. Thanks!

  • alexpott committed 3559826 on 8.0.x
    Issue #2251861 by olli, jibran: Add the feed icon back to taxonomy/term...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.