CommentFileSizeAuthor
#141 2208061_141.patch200.76 KBchx
#141 2208061_141.patch200.76 KBchx
#139 2208061_137.patch181.91 KBchx
#135 2208061_135.patch181.81 KBchx
#135 2208061_135.patch181.81 KBchx
#133 2208061_131.patch168.65 KBchx
#129 2208061_127.patch163.83 KBchx
#129 2208061_127.patch163.83 KBchx
#128 2208061_127.patch163.83 KBchx
#125 2208061_125.patch156.81 KBchx
#123 2208061_123.patch156.58 KBchx
#119 2208061_118.patch146.9 KBchx
#116 autoescape-2208061-116.patch122.1 KBjoelpittet
#111 2208061_110.patch118.76 KBchx
#111 2208061_110.patch118.76 KBchx
#111 2208061_110.patch118.76 KBchx
#110 2208061_110.patch118.76 KBchx
#108 2208061_108.patch111.17 KBchx
#105 2208061_105.patch99.12 KBchx
#103 2208061_103.patch96.92 KBchx
#99 autoescape-2208061-99.patch90.58 KBkgoel
#97 2208061_97.patch89.08 KBchx
#94 autoescape-2208061-94.patch402.68 KBkgoel
#92 autoescape-2208061-90.patch691 byteskgoel
#89 autoescape-2208061-89.patch81.29 KBjoelpittet
#86 autoescape-2208061-86.patch81.86 KBjoelpittet
#86 interdiff.txt781 bytesjoelpittet
#83 autoescape-2208061-83.patch81.88 KBjoelpittet
#81 2208061_81.patch82.11 KBchx
#80 2208061_80.patch80.2 KBchx
#77 2208061_77.patch73.88 KBchx
#75 2208061_74.patch72.47 KBchx
#72 2208061_72.patch73.04 KBchx
#70 2208061_70.patch72.25 KBchx
#68 2208061_68.patch63 KBchx
#66 2208061_66.patch62.46 KBchx
#64 2208061_64.patch59.23 KBchx
#62 2208061_61.patch58.77 KBchx
#60 2208061_59.patch57.92 KBchx
#58 2208061_57.patch58.77 KBchx
#56 2208061_55.patch52.86 KBchx
#54 2208061_54.patch51.67 KBchx
#52 2208061_52.patch48.12 KBchx
#50 2208061_49.patch47.77 KBchx
#47 2208061_47.patch48 KBchx
#46 2208061_45.patch47.43 KBchx
#44 2208061_44.patch44.01 KBchx
#43 2208061_40.patch1010.18 KBchx
#40 2208061_38.patch1007.36 KBchx
#36 2208061_36.patch1009.45 KBchx
#34 2208061_34.patch1011.37 KBbenjy
#32 2208061_31_full.patch1008.78 KBchx
#30 2208061_30_full.patch1011.96 KBchx
#29 d6_files.txt1.71 KBchx
#29 2208061_27.patch381.45 KBchx
#25 2208061_25_full.patch998.83 KBchx
#25 2208061_25.patch356.18 KBchx
#24 2208061_20.patch355.88 KBchx
#24 d6_files.txt920 byteschx
#20 d6_files.txt826 byteschx
#20 2208061_19.patch351.31 KBchx
#18 d6_files.txt655 byteschx
#18 2208061_19.patch345.3 KBchx
#16 2208061_16_full.patch998.52 KBchx
#16 2208061_16.patch343.45 KBchx
#14 2208061_13.patch328.78 KBbenjy
#12 2208061_12.patch330.1 KBbenjy
#8 2208061_7.patch310.05 KBchx
#6 2208061_6.patch969.03 KBchx
#5 2208061_5.patch329.19 KBchx
#4 2208061_3.patch917.63 KBchx
#3 2208061_2.patch902.06 KBchx
#1 2208061_1.patch904.41 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_1.patch904.41 KB
chx’s picture

chx CreditAttribution: chx commented
Status: Active » Needs review
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_2.patch902.06 KB
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_3.patch917.63 KB
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_5.patch329.19 KB 
git diff upstream/8.x core/modules/migrate  > 2208061_5.patch
git diff --diff-filter=M upstream/8.x core/modules/migrate  >> 2208061_5.patch
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_6.patch969.03 KB

The last submitted patch, 5: 2208061_5.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_7.patch310.05 KB

git diff upstream/8.x core/modules/migrate > 2208061_7.patch
git diff --diff-filter=M upstream/8.x core/modules/migrate_drupal >> 2208061_7.patch

Status: Needs review » Needs work

The last submitted patch, 8: 2208061_7.patch, failed testing.

The last submitted patch, 6: 2208061_6.patch, failed testing.

The last submitted patch, 6: 2208061_6.patch, failed testing.

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs work » Needs review
FileSize
2208061_12.patch330.1 KB

Looks like the patch didn't get a dependant file, this is the same patch with the Drupal6DumpBase as well.

Status: Needs review » Needs work

The last submitted patch, 12: 2208061_12.patch, failed testing.

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs work » Needs review
FileSize
2208061_13.patch328.78 KB

Let's try that again.

Status: Needs review » Needs work

The last submitted patch, 14: 2208061_13.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_16.patch343.45 KB
2208061_16_full.patch998.52 KB

git diff upstream/8.x core/modules/migrate > 2208061_16.patch
git diff --diff-filter=M upstream/8.x core/modules/migrate_drupal >> 2208061_16.patch
git diff upstream/8.x -- `cat d6_files` >> 2208061_16.patch

d6_files is:

core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/Dump/Drupal6DumpBase.php
core/modules/migrate_drupal/lib/Drupal/migrate_drupal/MigrationStorageController.php
core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Entity/Migration.php
core/modules/migrate_drupal/migrate_drupal.services.yml
core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Entity/MigrationInterface.php
core/modules/migrate_drupal/lib/Drupal/migrate_drupal/MigrationStorageController.php
core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d6/MigrateSystemConfigsTest.php

The last submitted patch, 16: 2208061_16.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_19.patch345.3 KB
d6_files.txt655 bytes

Status: Needs review » Needs work

The last submitted patch, 18: 2208061_19.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_19.patch351.31 KB
d6_files.txt826 bytes
chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 20: 2208061_19.patch, failed testing.

The last submitted patch, 20: 2208061_19.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
d6_files.txt920 bytes
2208061_20.patch355.88 KB
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_25.patch356.18 KB
2208061_25_full.patch998.83 KB

One more with the entity id patch applied.

chx’s picture

chx CreditAttribution: chx commented
Issue summary: View changes

The last submitted patch, 24: 2208061_20.patch, failed testing.

The last submitted patch, 25: 2208061_25.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_27.patch381.45 KB
d6_files.txt1.71 KB
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_30_full.patch1011.96 KB

Status: Needs review » Needs work

The last submitted patch, 30: 2208061_30_full.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_31_full.patch1008.78 KB

Status: Needs review » Needs work

The last submitted patch, 32: 2208061_31_full.patch, failed testing.

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs work » Needs review
FileSize
2208061_34.patch1011.37 KB

Status: Needs review » Needs work

The last submitted patch, 34: 2208061_34.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_36.patch1009.45 KB

Actually we found a tiny bug here in the statistics dump.

Status: Needs review » Needs work

The last submitted patch, 36: 2208061_36.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review

36: 2208061_36.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 36: 2208061_36.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_38.patch1007.36 KB
chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 40: 2208061_38.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_40.patch1010.18 KB
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_44.patch44.01 KB

Status: Needs review » Needs work

The last submitted patch, 44: 2208061_44.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_45.patch47.43 KB
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_47.patch48 KB

The last submitted patch, 46: 2208061_45.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 47: 2208061_47.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_49.patch47.77 KB

D'oh!

Status: Needs review » Needs work

The last submitted patch, 50: 2208061_49.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_52.patch48.12 KB

Status: Needs review » Needs work

The last submitted patch, 52: 2208061_52.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_54.patch51.67 KB

Status: Needs review » Needs work

The last submitted patch, 54: 2208061_54.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_55.patch52.86 KB

Status: Needs review » Needs work

The last submitted patch, 56: 2208061_55.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_57.patch58.77 KB

Status: Needs review » Needs work

The last submitted patch, 58: 2208061_57.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_59.patch57.92 KB

Status: Needs review » Needs work

The last submitted patch, 60: 2208061_59.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_61.patch58.77 KB

I'm not in love with git when git apply --index --reject skips the --index part :/

Status: Needs review » Needs work

The last submitted patch, 62: 2208061_61.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_64.patch59.23 KB

Status: Needs review » Needs work

The last submitted patch, 64: 2208061_64.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_66.patch62.46 KB

Status: Needs review » Needs work

The last submitted patch, 66: 2208061_66.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_68.patch63 KB

Status: Needs review » Needs work

The last submitted patch, 68: 2208061_68.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_70.patch72.25 KB

Status: Needs review » Needs work

The last submitted patch, 70: 2208061_70.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_72.patch73.04 KB
chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 72: 2208061_72.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_74.patch72.47 KB

Status: Needs review » Needs work

The last submitted patch, 75: 2208061_74.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_77.patch73.88 KB
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 77: 2208061_77.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_80.patch80.2 KB
chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_81.patch82.11 KB

Status: Needs review » Needs work

The last submitted patch, 81: 2208061_81.patch, failed testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
FileSize
autoescape-2208061-83.patch81.88 KB
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs work » Needs review

The last submitted patch, 80: 2208061_80.patch, failed testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
FileSize
interdiff.txt781 bytes
autoescape-2208061-86.patch81.86 KB

Testing if we can always cast and escape variables coming through checkplain.

The last submitted patch, 83: autoescape-2208061-83.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 86: autoescape-2208061-86.patch, failed testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
FileSize
autoescape-2208061-89.patch81.29 KB
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 89: autoescape-2208061-89.patch, failed testing.

kgoel’s picture

kgoel CreditAttribution: kgoel commented
FileSize
autoescape-2208061-90.patch691 bytes
kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Needs work » Needs review
kgoel’s picture

kgoel CreditAttribution: kgoel commented
FileSize
autoescape-2208061-94.patch402.68 KB

The last submitted patch, 92: autoescape-2208061-90.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 94: autoescape-2208061-94.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
2208061_97.patch89.08 KB

Status: Needs review » Needs work

The last submitted patch, 97: 2208061_97.patch, failed testing.

kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Needs work » Needs review
FileSize
autoescape-2208061-99.patch90.58 KB

Status: Needs review » Needs work

The last submitted patch, 99: autoescape-2208061-99.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented

97: 2208061_97.patch queued for re-testing.

The last submitted patch, 97: 2208061_97.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_103.patch96.92 KB

Status: Needs review » Needs work

The last submitted patch, 103: 2208061_103.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_105.patch99.12 KB
chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 105: 2208061_105.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_108.patch111.17 KB

Status: Needs review » Needs work

The last submitted patch, 108: 2208061_108.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_110.patch118.76 KB
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_110.patch118.76 KB
2208061_110.patch118.76 KB
2208061_110.patch118.76 KB

The last submitted patch, 111: 2208061_110.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 111: 2208061_110.patch, failed testing.

The last submitted patch, 111: 2208061_110.patch, failed testing.

The last submitted patch, 110: 2208061_110.patch, failed testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs work » Needs review
FileSize
autoescape-2208061-116.patch122.1 KB

Status: Needs review » Needs work

The last submitted patch, 116: autoescape-2208061-116.patch, failed testing.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Parent issue: » #1825952: Turn on twig autoescape by default

Adding parent issue, so we can easily find this working issue from the main issue.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_118.patch146.9 KB

Steadily and slowly...

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 119: 2208061_118.patch, failed testing.

bdragon’s picture

bdragon CreditAttribution: bdragon commented

I reckon most of the update.module failing tests can be sorted out by pushing the twigification stuff through for that module.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_123.patch156.58 KB

Status: Needs review » Needs work

The last submitted patch, 123: 2208061_123.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_125.patch156.81 KB
bdragon’s picture

bdragon CreditAttribution: bdragon commented
Status: Needs work » Needs review

Doctor testbot, you are needed in the lobby.

Status: Needs review » Needs work

The last submitted patch, 125: 2208061_125.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_127.patch163.83 KB
chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_127.patch163.83 KB
2208061_127.patch163.83 KB

The last submitted patch, 129: 2208061_127.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 129: 2208061_127.patch, failed testing.

The last submitted patch, 128: 2208061_127.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_131.patch168.65 KB

Status: Needs review » Needs work

The last submitted patch, 133: 2208061_131.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
FileSize
2208061_135.patch181.81 KB
2208061_135.patch181.81 KB
chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review

The last submitted patch, 135: 2208061_135.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 135: 2208061_135.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_137.patch181.91 KB

Status: Needs review » Needs work

The last submitted patch, 139: 2208061_137.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Needs review
FileSize
2208061_141.patch200.76 KB
2208061_141.patch200.76 KB

Status: Needs review » Needs work

The last submitted patch, 141: 2208061_141.patch, failed testing.

The last submitted patch, 141: 2208061_141.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Closed (works as designed)

Continued in #2280195: Ignore: patch testing issue