Break the circular dependency in EntityManager

I do consider this as a duplicate of #2182055: Comment module causes Circular reference error on a REST request. The actual issue is that the user is authenticated way to early.

As a developer I would totally not understand why entity forms as sooo different to entity lists or entity view builder. This fix sort of just fixes the symptons of the issue. The real fix would be that the current user is actually some sort of factory and the authentication manager is injected via setter injection. Damian wanted to work on it.

PS: please also try to provide the code you did to get to this statement.

When trying to make FormBuilder an explicit dependency of EntityManager, I got this:

Oh btw. I think that using setter injection for the form builder would already solve it.

1. +++ b/core/lib/Drupal/Core/Controller/ControllerBase.php
   @@ -114,6 +121,19 @@ protected function entityManager() {
      /**
   +   * Retrieves the entity form builder.
   +   *
   +   * @return \Drupal\Core\Entity\EntityFormBuilderInterface
   +   *   The entity form builder.
   +   */
   +  protected function entityFormBuilder() {
   

   It seems to be quite common, especially for core, to build entity forms on arbitrary controllers.

2. +++ b/core/modules/forum/lib/Drupal/forum/Controller/ForumController.php
   @@ -21,7 +20,7 @@
   +class ForumController extends ControllerBase implements ContainerInjectionInterface {
   ...
   -class ForumController implements ContainerInjectionInterface {
   

   So why don't we just inject the entity form builder now? We already have quite a lot of services in your create method.

2) This follows the pattern for other dependencies exposed by ControllerBase. It won't be as bad when #2110501: ControllerBase should implement ContainerInjectionInterface like FormBase is finally committed.

Well, I think that using ControllerBase for the sake of a single service is not worth it. Declaring explicit dependencies is still far better.

entity-form-2183923-11.patch no longer applies.

entity-form-2183923-15.patch no longer applies.

error: patch failed: core/modules/options/lib/Drupal/options/Tests/OptionsFieldTest.php:35
error: core/modules/options/lib/Drupal/options/Tests/OptionsFieldTest.php: patch does not apply
error: patch failed: core/modules/search/lib/Drupal/search/Controller/SearchController.php:87
error: core/modules/search/lib/Drupal/search/Controller/SearchController.php: patch does not apply
error: patch failed: core/modules/system/tests/modules/entity_test/entity_test.module:287
error: core/modules/system/tests/modules/entity_test/entity_test.module: patch does not apply

It feels wrong to not edit the issue all the time :P

Committed fe61b43 and pushed to 8.x. Thanks!

Before this change:

$advancedtour = $this->manager->getStorageController('advancedtour')->create(array());
return \Drupal::entityManager()->getForm($advancedtour);

Worked just fine.

However now with getForm function moving to EntityFormBuilder :

$advancedtour = $this->manager->getStorageController('advancedtour')->create(array());
return \Drupal::service('entity.form_builder')->getForm($advancedtour);

produces the error:

Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "advancedtour" entity type did not specify a "default" form class. in Drupal\Core\Entity\EntityManager->getFormController() (line 206 of C:\wamp\www\d8_feb09\core\lib\Drupal\Core\Entity\EntityManager.php).

Adding a default form to the annotation of the advancedtour and clearing the cache changed nothing. Still getting the error. Suggestions?

Nevermind, figured it out.