Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Same as #2162407: Split up toolbar.js and #2162409: Split up contextual.js.
Needs renaming from Drupal.contextualToolbar.VisualView
to Drupal.contextual.ToolbarVisualView
.
Comment | File | Size | Author |
---|---|---|---|
#14 | split_contextual_toolbar_js-2162837-14.patch | 18.36 KB | Wim Leers |
Comments
Comment #1
jibranI haven't done the renaming part yet.
contextual.toolbar.js
has a model attributeand we are also doing
if (Drupal.contextual && Drupal.contextual.collection) {
So I don't think that we can move
Drupal.contextualToolbar.model
toDrupal.contextual.ToolbarModel
because if we want to moveDrupal.contextualToolbar.VisualView
toDrupal.contextual.ToolbarVisualView
then we have to changeto
which is not right.
Comment #2
nod_Umm that's fair enough. Good for me, thanks !
We'll see about the renaming once we get around documenting that stuff.
Comment #4
jibranForgot to add a file.
Comment #5
nod_All good, thanks.
Comment #6
xjm4: d8.split-contextual.toolbar.js_.2162837-4.patch queued for re-testing.
Comment #7
nod_4: d8.split-contextual.toolbar.js_.2162837-4.patch queued for re-testing.
Comment #9
nod_Comment #10
jibranReroll
Comment #11
Wim LeersThis patch conflicts with #2162409: Split up contextual.js. Let's get that one in first.
Comment #12
webchickThat one's in, this will need a re-roll.
Comment #13
jibranWe can't split it as it is. First we have to change the Model and Views name because we already have
AuralView.js
forDrupal.contextual.AuralView
so we have to rename theDrupal.contextualToolbar.AuralView
.Comment #14
Wim LeersYep. Here's a patch that does all that.
Comment #15
jibranNice approach. And thanks for Hijeacking my patch :P :D. I'll let @nod_ RTBC it.
Comment #16
Wim LeersSorry! I really needed needed a break from the huge patches I've been working on. Glad you like it!
Comment #17
jessebeach CreditAttribution: jessebeach commentedThe patch still applies.
I manually tested and found no regressions. This patch just pushes some code around into separate files; it does not alter the existing behavior.
Looks good to go.
Comment #19
Wim LeersTestbot is broken ATM, see #2248217: Update Drush to newer SHA1.
Comment #20
jibran14: split_contextual_toolbar_js-2162837-14.patch queued for re-testing.
Comment #21
Wim LeersBack to RTBC as per #17.
Comment #23
jessebeach CreditAttribution: jessebeach commented14: split_contextual_toolbar_js-2162837-14.patch queued for re-testing.
Comment #24
Wim LeersGreen again, back to RTBC again, again as per #17.
Comment #25
webchickCommitted and pushed to 8.x. Thanks!
Comment #27
Wim Leers