Part of #1839338: [meta] Remove drupal_set_*() drupal_add_*() in favour of #attached/response for out-of-band stuff.

CommentFileSizeAuthor
#8 interdiff.txt738 bytesWim Leers
#8 2160581-drupal_add-install-core-8.patch1.46 KBWim Leers
#7 2160581-diff-3-7.txt1.61 KBvijaycs85
#7 2160581-drupal_add-install-core-7.patch1.47 KBvijaycs85
#3 2160581-drupal_add-install-core-3.patch1.52 KBvijaycs85
#3 2160581-diff-1-3.txt1.46 KBvijaycs85
#1 2160581-drupal_add-install-core-1.patch868 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
2160581-drupal_add-install-core-1.patch868 bytes

Initial patch...

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Intendation issues. While we are here we can maybe also attach the library?

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Title: Remove drupal_add_js() from install.core.inc » Remove drupal_add_js() + drupal_add_library() from install.core.inc
FileSize
2160581-diff-1-3.txt1.46 KB
2160581-drupal_add-install-core-3.patch1.52 KB

yep, here we go.

The last submitted patch, 1: 2160581-drupal_add-install-core-1.patch, failed testing.

The last submitted patch, 1: 2160581-drupal_add-install-core-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2160581-drupal_add-install-core-3.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
2160581-drupal_add-install-core-7.patch1.47 KB
2160581-diff-3-7.txt1.61 KB

Ok, lets try with $form

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community
FileSize
2160581-drupal_add-install-core-8.patch1.46 KB
interdiff.txt738 bytes

Works well. Manually tested. RTBC.

Only one nitpick: a newline was added for no reason. Removing that again.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.