Convert theme_textarea() to Twig

Not sure about including element into twig template. Any ideas?

+++ b/core/modules/system/templates/textarea.html.twig
@@ -0,0 +1,18 @@
+<div{{ wrapper_attributes }}><textarea {{ attributes }}>{{ value }}</textarea></div>

You can remove the space before the {{ attributes }}

That's may be the only issue, or the array_merge may be clobbering something...

Removed whitespace as joelpittet suggested in #4. Let's see if now it works.

+++ b/core/includes/form.inc
@@ -2575,22 +2575,23 @@ function theme_form($variables) {
+  $variables['wrapper_attributes'] = array(

Oh this need to be wrapped in new Attribute()... a good reason we shouldn't have magic wrapped special case variable keys #2108771: Remove special cased title_attributes and content_attributes for Attribute creation

Not sure if I understood it well. Let's see :)

+++ b/core/includes/form.inc
@@ -2575,34 +2575,36 @@ function theme_form($variables) {
+  $variables['attributes']['class'] = array();
+  $variables['attributes']['class'][] = 'form-textarea';
+  $variables['attributes']['class'] = array_merge($variables['attributes']['class'], $element['#attributes']['class']);

I'm quite sure it has to do with the change in how the attributes are being created. I don't know what _form_set_attributes() really does but glad to see it gone as I doubt it's needed. Though it would be worth checking those failed tests to see what the diff is between the attributes. A debug() call in those tests will help.

I think _form_set_attributes is needed, because it also adds a required class and other stuff when necessary.

Fixed wrong indentation.

wrong test; sorry

=== 8.x..8.x compared (52e436ce9c71d..52e43719571bf):

ct  : 69,806|69,806|0|0.0%
wt  : 260,668|261,804|1,136|0.4%
cpu : 246,347|247,292|945|0.4%
mu  : 18,775,848|18,777,112|1,264|0.0%
pmu : 18,830,136|18,831,080|944|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=52e436ce9c71d&...

=== 8.x..2152229-theme-textarea compared (52e436ce9c71d..52e4374042ace):

ct  : 69,806|70,331|525|0.8%
wt  : 260,668|261,833|1,165|0.4%
cpu : 246,347|247,360|1,013|0.4%
mu  : 18,775,848|18,857,080|81,232|0.4%
pmu : 18,830,136|18,910,312|80,176|0.4%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=52e436ce9c71d&...

Scenario for this profiling:
0. setup Seven 8.0-dev as default theme
1. added additional field to article content type.
2. created node as article type.
3. setup page as front page
4. allowed anonymous user to view, post, edit, and skip comment approval
5. run tests

Results of manual comparison:
Original - clean

Patched

Results of manual comparison:
Original - clean

<div class="form-textarea-wrapper"><textarea class="text-full form-textarea required resize-vertical" id="edit-comment-body-0-value" name="comment_body[0][value]" rows="5" cols="60" placeholder="" required="required" aria-required="true"></textarea></div>
</div>

Patched

<!-- THEME DEBUG -->
<!-- CALL: theme('textarea') -->
<!-- BEGIN OUTPUT from 'core/modules/system/templates/textarea.html.twig' -->
<div class="form-textarea-wrapper"><textarea class="text-full form-textarea required resize-vertical" id="edit-comment-body-0-value" name="comment_body[0][value]" rows="5" cols="60" placeholder="" required="required" aria-required="true"></textarea></div>

<!-- END OUTPUT from 'core/modules/system/templates/textarea.html.twig' -->

Great work all! This is ready to go. Patch passes testbot and Profiling and Manual Testing complete.

@burgerboydaddy thanks for the profiling and manual reviews! And joining in on the sprint in Vancouver.

We do not need that in there, That issue can deal with itself when we get to them, I'd rather not commit code with @todo's if we can help it. Please remove:)

Removed deprecated lines and added interdiff :)

28: convert-theme-textarea-2152229-28.patch queued for re-testing.

Test passed. Needs review.

Thanks @InternetDevels for removing those todo lines.

This has been profiled in #23 and markup compare in #25. Back to RTBC:)

Committed and pushed to 8.x. Thanks!