We found an issue in image_gd_rotate function. That's because of behaviour of imagerotate function in 2.1.1-dev version of gd library (PHP 5.5.6-1+debphp.org~precise+2). If you pass -1 as third parameter to this function, it returns false, but if you pass the same values in 2.1.0 version of gd library (PHP 5.3.27-1~dotdeb.0), it returns the rotated image. To avoid errors on 2.1.1-dev version our proposition is to use white color if imagecolortransparent function above returns -1.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

twistor’s picture

Re-uploading for testbot.

Status: Needs review » Needs work

The last submitted patch, 2: system-rotation-background-fix-2148861.patch, failed testing.

teknocat’s picture

InternetDevil's patch in comment #1 seems to be the right fix.

The problem here is that the imagecolortransparent function always returns a -1 when there is no transparent colour in the image, but on line 136 where it tests to see if there is no transparent colour it is checking to see if the return value is zero.

Documentation for imagecolortransparent:
http://php.net/manual/en/function.imagecolortransparent.php

twistor’s picture

Status: Needs work » Closed (duplicate)