Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
the only function in this file is used by views_ui module only
Comment | File | Size | Author |
---|---|---|---|
#31 | move_ajax_inc_to_views_ui_module-2146473-31.patch | 15.81 KB | vprocessor |
#21 | 2146473-21.patch | 15.48 KB | damiankloip |
Comments
Comment #1
andypostSuppose better leave this method protected and no idea about better name
Comment #2
dawehner@andypost
Your patch is totally fine and is the way how much of the code got converted.
Here is an alternative approach which decouples the code more and provides a form wrapper which is orthogonal.
Comment #3
andypostPatch looks awesome! let's see do we have a tests for this class because
this line was missed, so probably testing should fail
Comment #4
dawehnerGood catch! Decided also to write a little unit test.
Comment #5
andypostRTBC +1
Comment #6
damiankloip CreditAttribution: damiankloip commentedComment #7
alexpottComment #8
damiankloip CreditAttribution: damiankloip commentedRerolled
Comment #9
damiankloip CreditAttribution: damiankloip commented8: 2146473-8.patch queued for re-testing.
Comment #12
dawehner8: 2146473-8.patch queued for re-testing.
Comment #13
dawehnerLet's get it out.
Comment #14
webchickSorry, once again no longer applies.
Comment #15
dawehnerHere is one.
Comment #16
andypostback to rtbc
Comment #17
alexpottNeeds yet another reroll...
Comment #18
damiankloip CreditAttribution: damiankloip commentedRerolled.
Comment #20
dawehner----
Comment #21
damiankloip CreditAttribution: damiankloip commentedSorry, missed a change from the reroll that was in #2102489: Remove drupal_set_title in views module controllers (last instance of drupal_set_title() in modules).
Comment #23
andypostComment #24
vprocessor CreditAttribution: vprocessor at Skilld commentedComment #25
vprocessor CreditAttribution: vprocessor at Skilld commentedHello guys,
reroll is ready
Comment #26
vprocessor CreditAttribution: vprocessor at Skilld commentedComment #27
andypost+2 rtbc
Comment #28
damiankloip CreditAttribution: damiankloip commentedThis can also be removed and converted.
This can be removed.
And this.
Comment #29
vprocessor CreditAttribution: vprocessor at Skilld commentedComment #30
vprocessor CreditAttribution: vprocessor at Skilld commentedok, will do it
Comment #31
vprocessor CreditAttribution: vprocessor at Skilld commenteddone
Comment #32
vprocessor CreditAttribution: vprocessor at Skilld commentedComment #33
vprocessor CreditAttribution: vprocessor at Skilld commentedComment #34
andypostYou missed to remove ajax.inc in patch
nit
Comment #35
andypostThere's no such file like issue title said but there's http://cgit.drupalcode.org/drupal/tree/core/modules/views_ui/admin.inc - the last include in views
Comment #36
andypostQuick research returns http://cgit.drupalcode.org/drupal/commit/?id=7b83db3
So #2303761: Move views_ajax_form_wrapper() to ViewsFormBase fixed the issue
Suppose we need to re-title this one about adding new tests
Comment #37
andypost@damiankloip any idea what to do with the issue
Comment #51
smustgrave CreditAttribution: smustgrave at Mobomo commentedPostponing for subsystem feedback.