Updated: Comment #0

Problem/Motivation

In #2076445: Make sure language codes for original field values always match entity language regardless of field translatability we changed how field language is stored for untranslatable fields: previously they always got the 'und' language code, now they always match the language of the entity they are attached to. Since retrieving the entity language requires the Entity API, we cannot write an update function to upgrade existing databases.

Proposed resolution

Write a migration as soon as we have a proper Migration API in place.

Remaining tasks

Write a patch
Reviews

User interface changes

None

API changes

None

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue summary: View changes
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Related issues: -#2125717: Migrate in core: patch #1 +#2121299: Migrate in Core: Drupal 6 to Drupal 8
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Priority: Critical » Major

Downgrading to major since this doesn't actually block 8.0. However we'll need to bump all these after release if we want to block the first minor on them.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Postponed » Active

Can we unpostpone this?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Component: field system » migration system
Issue tags: +i18n-migrate

Stumbled on this looking for something else.

Since this is about migrating fields, moving to the migration system and tagging for i18n-migrate. Not sure if this is already fixed.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented
Issue tags: +Needs tests

Can someone provide a test demonstrating the problem (if there is one)?

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented
Status: Active » Closed (works as designed)

As near as I can tell, this works just fine in practice - migrated fields have the language code of the entity revision they're attached to. If anyone sees a problem with this, please reopen and provide a fail test (or at least reproducible steps) demonstrating a scenario where it doesn't work.