Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
modules/image/image.install:236: update_variables_to_config('image.settings'
Thanks in advance for helping many hands to make light work!
See #2181257: [meta] Variables to config migration [d7] for instructions
Comment | File | Size | Author |
---|---|---|---|
#29 | 2130283-29.patch | 2.68 KB | quietone |
#27 | 2130283-27.patch | 2.76 KB | quietone |
#23 | interdiff-2130283-20-23.txt | 2.07 KB | quietone |
#23 | 2130283-23.patch | 2.76 KB | quietone |
#20 | 2130283-20.patch | 1.83 KB | phenaproxima |
Comments
Comment #1
fastangel CreditAttribution: fastangel commentedI think that this issue should be postponed to D7. Right now the variables in D8:
Itok integration was introduced in D7 see this for more information https://drupal.org/node/1934498
About insecure derivations was added in D7 7.20 see release note: https://drupal.org/drupal-7.20-release-notes
And the end the module in D6 isn't use any variable.
Comment #3
eliza411 CreditAttribution: eliza411 commentedMoving to the core queue to consolidate issues now that we're doing all the work there.
Comment #4
eliza411 CreditAttribution: eliza411 commentedThis one didn't need to be assigned
Comment #5
eliza411 CreditAttribution: eliza411 commentedComment #6
samhassell CreditAttribution: samhassell commentedComment #7
samhassell CreditAttribution: samhassell commentedpreview_image doesn't exist in d7 so no need to migrate it. These other two allow_insecure_derivatives and suppress_itok_output are straight forward boolean mappings so no complexity there I don't think.
Couldn't get the test suite working on my local so submitting for testbot.
Comment #8
samhassell CreditAttribution: samhassell commentedtests now passing.
Comment #9
benjy CreditAttribution: benjy commentedCommitted to the
drupal7
branch, fixed a small formatting issue on the way in.Comment #11
jcost CreditAttribution: jcost commentedWill need to be submitted again to Core since moving from sandbox.
Comment #12
phenaproximaRerolled against 8.0.x, with a test of the d7_image_settings migration.
Comment #13
phenaproximaSlight cleanup of the test.
Comment #15
phenaproximaBlocked by #2495755: Create MigrateDrupal7TestBase.
Comment #16
phenaproximaComment #17
phenaproximaNeeds to be merged into the parent issue.
Comment #18
phenaproximaNeeds to be re-rolled with fewer alterations to the {variable} dump.
Comment #19
phenaproximaWe be re-rollin'. Testbot, don't be hatin'.
Comment #20
phenaproximaRe-rolled again. No interdiff due to merge conflict with Variable.php dump.
Comment #21
mikeryanThis looks straight-forward enough - but, despite what #7 says, in the D7 code base I see
I see absolutely no other reference to that variable in my D7 code base. I do see it included in #469798: Document variables without an UI. Should we migrate it?
Comment #22
phenaproximaIf it exists in core, even for a single usage, I think we should migrate it.
Comment #23
quietone CreditAttribution: quietone commentedAdded image_style_preview_image.
Comment #26
phenaproximaComment #27
quietone CreditAttribution: quietone commentedReroll.
Comment #28
phenaproximaAlmost there.
We might not actually need this line; if the test still passes without it, kill it. :)
This should be removed.
$this->config()
Let's use $config->get() here, for consistency.
Comment #29
quietone CreditAttribution: quietone commentedBetter?
Comment #31
phenaproximaPerfect.
Comment #32
webchickCommitted and pushed to 8.0.x. Thanks!