Stop creating user_picture field programatically [#2124619]

In the standard profile install the function user_install_picture_field() creates the field programatically. This prevents configuration import across two standard profile installations.

Solution

Add default configuration for user_picture field.

Comment	File	Size	Author
#5	2124619.5.patch	9.65 KB	alexpott
#5
#5	3-5-interdiff.txt	630 bytes	alexpott
#3	2124619.3.patch	9.31 KB	alexpott
#3
#3	1-3-interdiff.txt	8.2 KB	alexpott
#1	2124619.1.patch	8.46 KB	alexpott
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 31 October 2013 at 07:37

Status:

Active

» Needs review

File	Size
2124619.1.patch	8.46 KB

Comment #2

damiankloip CreditAttribution: damiankloip commented 31 October 2013 at 08:01

+++ b/core/modules/user/tests/modules/user_picture_field/config/field.field.user.user_picture.yml
@@ -0,0 +1,31 @@
+id: user.user_picture

+++ b/core/modules/user/tests/modules/user_picture_field/config/field.instance.user.user.user_picture.yml
@@ -0,0 +1,24 @@
+id: user.user.user_picture

Is there a reason this lives in it's own module rather than just the standard profile config dir?

Comment #3

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 31 October 2013 at 08:39

File	Size
1-3-interdiff.txt	8.2 KB
2124619.3.patch	9.31 KB

@damiankloip that was for testing purposes but as @xjm pointed out this was not actually testing the standard profile anymore and the config in the test module could diverge.

This patch changes the tests to use standard profile thereby testing it.

Also more of the config can be provided as defaults.

Comment #4

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 6 November 2013 at 08:51

Closed #2114887: Maximum nesting level when attaching comment field to User. as a duplicate of this.
Basically if you add a comment field to the user entity, and don't call user_install_picture_field(), because you don't have a compact entity display for users, the call to user_view($account, 'compact'); in template_preprocess_comment creates an infinite loop as the compact view mode attempts to render the comment thread, which attempts to render the comment, which attempts to render the user - and so on.

Comment #5

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 6 November 2013 at 20:33

Issue summary:

View changes

File	Size
3-5-interdiff.txt	630 bytes
2124619.5.patch	9.65 KB

#1443606: Alt, title, width and height for default images has landed requiring a change to this.

Comment #6

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 6 November 2013 at 20:37

Re #4 I don't think this is going to fix that issue. Comment somehow needs to take care of that itself. It should not be assuming that compact exists whilst the compact configuration is in the standard profile. I'm going to re-open the other issue.

Comment #7

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 11 November 2013 at 10:45

5: 2124619.5.patch queued for re-testing.

Comment #8

damiankloip CreditAttribution: damiankloip commented 11 November 2013 at 16:58

Status:

Needs review

» Reviewed & tested by the community

+++ b/core/profiles/standard/config/entity.display.user.user.compact.yml
@@ -0,0 +1,16 @@
+    weight: 0
...
+    visible: false
+status: true

+++ b/core/profiles/standard/config/entity.form_display.user.user.default.yml
@@ -0,0 +1,13 @@
+    weight: -1

+++ b/core/profiles/standard/config/field.instance.user.user.user_picture.yml
@@ -0,0 +1,29 @@
+required: false
+default_value: {  }

Nice! Actual data types.

This patch looks good to me now. Everything is living in it's correct home.