Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcingy’s picture

Status: Active » Needs review
FileSize
9.56 KB

First patch

marcingy’s picture

FileSize
11.15 KB

Last patch had some issues with notices.

tim.plunkett’s picture

  1. +++ b/core/modules/language/lib/Drupal/language/Form/LanguageControllerForm.php
    @@ -0,0 +1,155 @@
    +    $settings = &$form_state['values']['settings'];
    

    Why is this by reference?

  2. +++ b/core/modules/language/lib/Drupal/language/Form/LanguageControllerForm.php
    @@ -0,0 +1,155 @@
    +  public function getFormID() {
    +    return 'language_content_settings_form';
    +  }
    

    This is usually the first method in form classes (after __construct/create)

tim.plunkett’s picture