Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
#1971384: [META] Convert page callbacks to controllers covers all controller-based forms, but there are plenty of others that need converting. Here's one.
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff.txt | 17.21 KB | sun |
#7 | authorize-2112557-7.patch | 27.98 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettComment #2
tim.plunkettRerolled.
Comment #4
tim.plunkett2: authorize-2112557-2.patch queued for re-testing.
Comment #5
tim.plunkettRerolled. Will get better with #2145007: Convert form_set_error() in FormBase classes to use FormErrorInterface
Comment #6
tim.plunkettRerolled
Comment #7
tim.plunkettRerolled
Comment #8
sun7: authorize-2112557-7.patch queued for re-testing.
Comment #9
sunAttaching an interdiff generated via
Comment #10
sunLooks good to me :-)
Comment #11
alexpottCommitted 4a6f248 and pushed to 8.x. Thanks!
This can never work! the connect method is an abstract protected method! Looking at the implementations maybe they are somehow making it public... who knows? http://3v4l.org/08n7b interesting :) Opening a new issue to fix this.
Comment #13
alexpottCreated #2242405: FileTransfer::connect is protected yet the implementations are public and this is relied upon. to address the comment in #11