Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
28.23 KB
tim.plunkett’s picture

Issue summary: View changes
FileSize
28.1 KB
5.99 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 2: authorize-2112557-2.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review

2: authorize-2112557-2.patch queued for re-testing.

tim.plunkett’s picture

FileSize
28.12 KB
tim.plunkett’s picture

FileSize
28.13 KB
1.27 KB

Rerolled

tim.plunkett’s picture

FileSize
27.98 KB

Rerolled

sun’s picture

7: authorize-2112557-7.patch queued for re-testing.

sun’s picture

FileSize
17.21 KB

Attaching an interdiff generated via

git diff -b 8.x:core/includes/authorize.inc core/lib/Drupal/Core/FileTransfer/Form/FileTransferAuthorizeForm.php
sun’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me :-)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4a6f248 and pushed to 8.x. Thanks!

+++ b/core/lib/Drupal/Core/FileTransfer/Form/FileTransferAuthorizeForm.php
@@ -0,0 +1,323 @@
+        $filetransfer->connect();

This can never work! the connect method is an abstract protected method! Looking at the implementations maybe they are somehow making it public... who knows? http://3v4l.org/08n7b interesting :) Opening a new issue to fix this.

  • Commit 4a6f248 on 8.x by alexpott:
    Issue #2112557 by tim.plunkett: Convert authorize_filetransfer_form to...
alexpott’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.