Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

views.view.test_serializer_display_entity.yml
views.view.test_serializer_display_field.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

CommentFileSizeAuthor
#4 2105979-rest-config-cleanup-4.patch4.26 KBvijaycs85
#1 2105979-1-rest-yaml-variable-type.patch1.87 KBalexander_danilenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexander_danilenko’s picture

alexander_danilenko CreditAttribution: alexander_danilenko commented
Assigned: Unassigned » alexander_danilenko
Status: Active » Needs review
FileSize
2105979-1-rest-yaml-variable-type.patch1.87 KB

Status: Needs review » Needs work

The last submitted patch, 2105979-1-rest-yaml-variable-type.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented 
  1. +++ b/core/modules/rest/rest.routing.yml
@@ -3,4 +3,4 @@ rest.csrftoken:
-    _access: 'TRUE'
+    _access: TRUE

    Sorry, my mistake this is not applicable for routing file. Removed this file from the list. 

  2. +++ b/core/modules/rest/tests/modules/rest_test_views/test_views/views.view.test_serializer_display_entity.yml
@@ -45,6 +45,6 @@ display:
-status: '1'
+status: 1

+++ b/core/modules/rest/tests/modules/rest_test_views/test_views/views.view.test_serializer_display_field.yml
@@ -41,9 +41,9 @@ display:
-          exclude: '0'
+          exclude: 0
...
-            alter_text: '1'
+            alter_text: 1

@@ -100,6 +100,6 @@ display:
-status: '1'
+status: 1

    bool should be true (for 1) and false (for 0)

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue summary: View changes

Updated issue summary.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
2105979-rest-config-cleanup-4.patch4.26 KB

Re-rolling...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Closed (duplicate)
Related issues: +#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.