Subtask of #1830588: [META] remove drupal_set_title() and drupal_get_title()

Problem/Motivation

Using procedural drupal_set_title() inside controller class is not encouraged.

Proposed resolution

Replace drupal_set_title() with #title in page return array.

Remaining tasks

Issue patch

User interface changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

API changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

CommentFileSizeAuthor
#1 drupal-remove_drupal_set_title_in_system_module-2102475-1.patch597 bytesInternetDevels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Active » Needs review
FileSize
drupal-remove_drupal_set_title_in_system_module-2102475-1.patch597 bytes

Here is the patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

This looks fine. I think we should open a follow up to return confirm_form() if it is not needed anymore.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)
Related issues: +#2143933: Add _title and _title_callback to all routes.

Fixed as part of #2143933: Add _title and _title_callback to all routes.. Sorry @InternetDevels, Should have got commit credit for you on #2143933: Add _title and _title_callback to all routes., but we are late :(

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented
Status: Closed (won't fix) » Closed (duplicate)