Subtask of #1830588: [META] remove drupal_set_title() and drupal_get_title()

Problem/Motivation

Using procedural drupal_set_title() inside controller class is not encouraged.

Proposed resolution

Replace drupal_set_title() with #title in page return array.

Remaining tasks

Issue patch

User interface changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

API changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

Status: Active » Needs review
FileSize
524 bytes
dawehner’s picture

Status: Needs review » Needs work
+++ b/core/modules/path/path.admin.inc
@@ -113,8 +113,8 @@ function path_admin_overview($keys = NULL) {
-    drupal_set_title($path['alias']);
...
+    $output['#title'] = $path['alias'];

Let's check plain the title here.

sidharthap’s picture

Status: Needs work » Needs review
FileSize
698 bytes

used check plain here.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

+1

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.