Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hello,
I installed Drupal 8.x, and saw some small CSS bug.
In this issue I fixed password element alignment in Configure site / SITE MAINTENANCE ACCOUNT fieldset.
Current status see in password_alignment_before.png and the fixed status see in password_alignment_after.png.
Patch is attached.
Comment | File | Size | Author |
---|---|---|---|
#25 | Screen Shot 2013-11-23 at 11.49.51 AM.png | 14.32 KB | webchick |
#21 | password-indicator-after.png | 19.3 KB | Manjit.Singh |
#21 | password-indicator-before.png | 19.94 KB | Manjit.Singh |
#19 | password-indicator-after.png | 63.89 KB | idebr |
#19 | password-indicator-before.png | 58.87 KB | idebr |
Comments
Comment #1
csakiistvanSorry the pictures name.
password_alignment_before.png = Képernyőfotó 2013-09-29 - 11.24.06.png
password_alignment_after.png = Képernyőfotó 2013-09-29 - 12.41.08.png
Comment #2
balintk CreditAttribution: balintk commentedThat alignment is indeed faulty, it's easy to reproduce. The provided patch makes it look nice.
Comment #3
dcrocks CreditAttribution: dcrocks commentedThe patch only works on narrow screens tried on latest d8-x.dev. Also see related #2044889: 'Password Match' alignment error during install.
Comment #4
dcrocks CreditAttribution: dcrocks commented#1811240: Improve "password matches" and "password strength" accessibility also overlaps this.
Comment #5
dcrocks CreditAttribution: dcrocks commentedPatch #1839318: Replace drupal.base.css library with normalize.css for all themes went in 9/28 and overlaps this one. This needs a reroll.
Comment #6
dcrocks CreditAttribution: dcrocks commentedPatch #1839318: Replace drupal.base.css library with normalize.css for all themes went in on 9/28 and overlaps this one. Needs a reroll?
Comment #7
emma.mariaThe patch applied fine but needed more work. There were bugs with how the fields were sitting next to the inputs when you went from small screen to big and also the fields dropping below too soon before they became 100% width. These issues have all been sorted and this patch is ready to test.
Comment #8
emma.mariaComment #9
dcrocks CreditAttribution: dcrocks commentedInstalled patch on current clone. Install page now looks OK but user' 'Create' page now bollixed. Was OK before this patch.
On entry:
After entering a password:
After entering confirmation password:
Comment #10
dcrocks CreditAttribution: dcrocks commentedAfter #1839318: Replace drupal.base.css library with normalize.css for all themes, this is all that should be needed to fix alignment errors in the password form.
Comment #11
LewisNyman#9 does not fix the alignment problem. They should sit alongside the input fields when there is room.
All #7 needs is an overflow hidden on the form items on the user creation form to stop them collapsing.
Comment #12
emma.mariaI have added the extra fix to #7 and tested the installer and the user pages. Everything looks spiffing :)
Emma
Comment #13
rteijeiro CreditAttribution: rteijeiro commentedTested and patch applies well. Code seems fine and here are some screenshots for each mediaquery that show that it's a RTBC ;)
Comment #15
emma.maria#12: password-alignment-installer-2100509-12.patch queued for re-testing.
Comment #16
mgiffordOk, I think the bot was wrong, in which case this is back to RTBC.
Comment #17
Xano#12: password-alignment-installer-2100509-12.patch queued for re-testing.
Comment #18
alexpottI would have thought that this might mess up rtl - since we have the following css in user.module.css
Comment #19
idebr CreditAttribution: idebr commentedalexpott is correct, see password-indicator-before.png
I have updated the LTR/RTL version and fixed some css coding standards, see password-indicator-after.png
Comment #20
Manjit.SinghCan anybody help me to find out how to change whole D8 site from RTL ? I want to review the issue queue but doesn't able to change site from right to left.
Comment #21
Manjit.SinghI have test the patch 2100509-19 manually. Please find the screenshots of before and after applying patch.
Comment #22
mgiffordI think you can just install it so that the primary language is Arabic or Hebrew and you should be able to see it in RTL.
EDIT: Or simpler, just add an Arabic/Hebrew language to your existing test environment & switch to it via the URL.
Comment #23
Manjit.SinghChanged to RTBC
Comment #24
s_gupta_14 CreditAttribution: s_gupta_14 commentedconfirmed patch works as required
Comment #25
webchickAwesome! This has been bugging the crap out of me in demos! :)
Confirmed in RTL as well. Don't ask me what this says, but it looks aligned. :)
Committed and pushed to 8.x, with a minor whitespace fix. Thanks!
Comment #26
webchickAlthough, come to think of it, does that CSS really better belong in a user.theme.css so that it's easy for themes to override the styling? (separate issue)