Support from Acquia helps fund testing for Drupal Acquia logo

Comments

csakiistvan’s picture

Sorry the pictures name.

password_alignment_before.png = Képernyőfotó 2013-09-29 - 11.24.06.png
password_alignment_after.png = Képernyőfotó 2013-09-29 - 12.41.08.png

balintk’s picture

Title: Ugly password alignment during installation setup » Password strength indicator for site maintenance account is aligned incorrectly on the installation screen
Status: Active » Needs review

That alignment is indeed faulty, it's easy to reproduce. The provided patch makes it look nice.

dcrocks’s picture

The patch only works on narrow screens tried on latest d8-x.dev. Also see related #2044889: 'Password Match' alignment error during install.

dcrocks’s picture

dcrocks’s picture

Status: Needs review » Needs work

Patch #1839318: Replace drupal.base.css library with normalize.css for all themes went in 9/28 and overlaps this one. This needs a reroll.

dcrocks’s picture

Patch #1839318: Replace drupal.base.css library with normalize.css for all themes went in on 9/28 and overlaps this one. Needs a reroll?

emma.maria’s picture

The patch applied fine but needed more work. There were bugs with how the fields were sitting next to the inputs when you went from small screen to big and also the fields dropping below too soon before they became 100% width. These issues have all been sorted and this patch is ready to test.

emma.maria’s picture

Status: Needs work » Needs review
dcrocks’s picture

FileSize
30.75 KB
32.99 KB
14.72 KB

Installed patch on current clone. Install page now looks OK but user' 'Create' page now bollixed. Was OK before this patch.
On entry:
User create
After entering a password:
User create
After entering confirmation password:
User create

dcrocks’s picture

After #1839318: Replace drupal.base.css library with normalize.css for all themes, this is all that should be needed to fix alignment errors in the password form.

LewisNyman’s picture

Status: Needs review » Needs work

#9 does not fix the alignment problem. They should sit alongside the input fields when there is room.

All #7 needs is an overflow hidden on the form items on the user creation form to stop them collapsing.

emma.maria’s picture

Status: Needs work » Needs review
FileSize
1.6 KB

I have added the extra fix to #7 and tested the installer and the user pages. Everything looks spiffing :)

Emma

rteijeiro’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
28.56 KB
28.05 KB
28.99 KB
28.38 KB

Tested and patch applies well. Code seems fine and here are some screenshots for each mediaquery that show that it's a RTBC ;)

password-small.png

password-narrow.png

password-medium.png

password-wide.png

Status: Reviewed & tested by the community » Needs work

The last submitted patch, password-alignment-installer-2100509-12.patch, failed testing.

emma.maria’s picture

Status: Needs work » Needs review
mgifford’s picture

Status: Needs review » Reviewed & tested by the community

Ok, I think the bot was wrong, in which case this is back to RTBC.

Xano’s picture

alexpott’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/user/css/user.module.css
@@ -51,11 +51,12 @@ input.password-confirm,
+  float:left;

I would have thought that this might mess up rtl - since we have the following css in user.module.css

[dir="rtl"] .password-strength-text {
  float: left;
}
idebr’s picture

alexpott is correct, see password-indicator-before.png

I have updated the LTR/RTL version and fixed some css coding standards, see password-indicator-after.png

Manjit.Singh’s picture

Can anybody help me to find out how to change whole D8 site from RTL ? I want to review the issue queue but doesn't able to change site from right to left.

Manjit.Singh’s picture

I have test the patch 2100509-19 manually. Please find the screenshots of before and after applying patch.

mgifford’s picture

I think you can just install it so that the primary language is Arabic or Hebrew and you should be able to see it in RTL.

EDIT: Or simpler, just add an Arabic/Hebrew language to your existing test environment & switch to it via the URL.

Manjit.Singh’s picture

Status: Needs review » Reviewed & tested by the community

Changed to RTBC

s_gupta_14’s picture

confirmed patch works as required

webchick’s picture

Status: Reviewed & tested by the community » Fixed
FileSize
14.32 KB

Awesome! This has been bugging the crap out of me in demos! :)

Confirmed in RTL as well. Don't ask me what this says, but it looks aligned. :)

RTL password indicator

Committed and pushed to 8.x, with a minor whitespace fix. Thanks!

webchick’s picture

Although, come to think of it, does that CSS really better belong in a user.theme.css so that it's easy for themes to override the styling? (separate issue)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.