Part of #2073819: [META] Remove direct calls to drupal_add_css().

Follows the same pattern that was used elsewhere, e.g. in #1969916: Remove drupal_add_js/css from seven.theme.

CommentFileSizeAuthor
#12 2096577-views-add-css-js-12.patch2.46 KBvijaycs85
#6 drupal_add_css-2096577-6.patch2.64 KBWim Leers
#6 interdiff.txt1019 bytesWim Leers
#1 drupal_add_css-2096577-1.patch2.08 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Needs review
FileSize
drupal_add_css-2096577-1.patch2.08 KB
sandergo90’s picture

sandergo90 CreditAttribution: sandergo90 commented

Patch looks good and drupal coding standards are applied. The css is loading on the page and all drupal_add_css tags have been removed.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: Remove drupal_add_css() from views.modujle » Remove drupal_add_css() from views.module

LOL, stupid typo

sandergo90’s picture

sandergo90 CreditAttribution: sandergo90 commented

Indeed ! :P

Status: Needs review » Needs work

The last submitted patch, drupal_add_css-2096577-1.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs work » Needs review
FileSize
interdiff.txt1019 bytes
drupal_add_css-2096577-6.patch2.64 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Parent issue: » #2073819: [META] Remove direct calls to drupal_add_css()

looks good, suppose ajax.inc will migrate to view_ui module soon

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +VDC

+1 (for the patch and the amount of tags)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Related issues: +#2146473: Move views/includes/ajax.inc to a class in views_ui module

There's some refactoring happens in #2146473: Move views/includes/ajax.inc to a class in views_ui module

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

6: drupal_add_css-2096577-6.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: drupal_add_css-2096577-6.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
2096577-views-add-css-js-12.patch2.46 KB

Re-rolling...

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.