Updated: Comment #0

Problem/Motivation

The target attribute is set to "0" when creating a link without checking the "Open in new window" checkbox. It should not be set at all when that checkbox is unchecked.

This is only a problem when inserting a link, not when editing a link.

Proposed resolution

When the value is "0", don't set the target attribute at all.

Remaining tasks

None.

User interface changes

None.

API changes

None.

#1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms

CommentFileSizeAuthor
#1 a_target_attribute-2093077-1.patch897 bytesWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Reviewed & tested by the community
Issue tags: +quickfix
FileSize
a_target_attribute-2093077-1.patch897 bytes

Trivial fix.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

RTBC++

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: -sprint

Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.