Updated: Comment 0

Problem/Motivation

As a side note, I've been trying to use this with the breadcrumbs conversion and it doesn't behave totally as expected. In particular there are points where the language handling is wrong generating link if we tweak this code to do this right(?) think and remove the attributes from the parent request.

Proposed resolution

Remaining tasks

User interface changes

API changes

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

Perhaps I was just doing something dumb in the patch, but we ought to at least understand the possible carry-over or side effects and make the duplicated request as close as possible to one from Request::create() while retaining the performance benefit.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Priority: Normal » Major

So, among other things dawehner has noticed attributes like _content carried over, which certainly could cause issues.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue summary: View changes
Status: Active » Fixed

We dropped RequestHelperalready.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

We have @todo in PathBasedBreadcrumbBuilder for this issue.


    // @todo Use the RequestHelper once https://drupal.org/node/2090293 is
    //   fixed.
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented

And still there :-)

idebr’s picture

idebr CreditAttribution: idebr at iO commented

I created an issue to remove the @todo: #3116147: Remove @todo pertaining to RequestHelper::duplicate(), which has been removed