Wrong name for datetime.html.twig should be time.html.twig

Taking this one.

Attached patch for this small change.

Please someone reroll the patch to update the documentation in the twig file.

Does this means that form element must be renamed to 'time' e.g

  $form['some'] = array(
    '#type' => 'datetime',
  );

must be

  $form['some'] = array(
    '#type' => 'time',
  );

To make this change you will need to update drupal_common_theme() as well:

https://api.drupal.org/api/drupal/core%21includes%21theme.inc/function/d...

Usually the template name matches up with the theme hook name - so I would suggest updating the theme hook to 'time', so that it is rendered via '#theme' => 'time' rather than '#theme' => 'datetime'.

That's great, thanks @undertext! Looks like this needs a reroll now.

We'll also need to update template_preprocess_datetime() to template_preprocess_time() - this is referenced in a @see in the Twig template.

The ideal result here will be a rerolled patch, an interdiff, and then a revised patch. The interdiff will show the differences between the rerolled patch and the revised patch (that updates the preprocess function).

Re-rolled

And now the template_preprocess_time change and interdiff

the patch is green, so... needs review.

Sorry, I forgot to set interdiff extension to .txt to avoid testing it :(

Patch no longer applies.

Uploading the rerolled patch.

20: datetime.html_.twig-to-time.html_.twig-2088365-20.patch queued for re-testing.

Thanks @sriharsha.uppuluri!

We need to rename template_preprocess_datetime() like in #14.

Thanks @Cottser

Renamed template_preprocess_datetime() like in #14.

i am updating patch #20 based on #22 comments.

Looking good, one minor tweak needed then this should be ready to go:

+++ b/core/includes/theme.inc
@@ -997,7 +997,7 @@ function theme_disable($theme_list) {
- * Preprocess variables for theme_datetime().
+ * Preprocess variables for theme_time().

While we're updating this it should follow our newer documentation standards for preprocess functions:

Preprocess function documentation standards

…and in particular it shouldn't refer to theme_time() because that doesn't exist :)

Changed the patch in #25 to incorporate changes suggested in #27.

The doc block now looks like:

/**
 * Preprocess variables for time templates.
 *
 * Default template: time.html.twig.
 *
 * @param array $variables

Thanks @cs_shadow!

Interdiff next time, please! And "Preprocess" should be "Prepares" according to the documentation standards.

Changed the patch as suggested in #29. Attaching interdiff.

Trying to fix the errors in #28.

I'm at the Austin core mentoring spring and I am going to reroll the latest patch.

Patch #32 failed to apply due to renaming of core/modules/datetime/lib directory to core/modules/datetime/src.

Tried to create interdiff but could not reroll patch due to corrupt patch error when applying.

Recreated patch to match latest core version.

At Drupalcon Austin - just tested patch in #35. Applies cleanly, looks to remove all references to datetime.html.twig updated to reviewed and tested.

Not sure about this, while the HTML5 element is called 'time', the thing being formatted is a datetime (and the HTML5 spec allows a datetime attribute for that element). The whole point of the template is to allow for changing the markup, which could include using a different element.

@catch, I was thinking along the same lines as you, it's such a blurry line here. Also very minor, I'd recommend making this change.

@_nod, I so wish we weren't so granular in the templates and let the templates live at a more component level or view mode level. That, or we may as well create a template for the whole html spec of tags. And the more granular the slower on the io and rendering... sorry I had to rant because I see these single tag templates with very little context and wonder how anybody builds a site in a reasonable amount of time with that level of templates. Like trying to build a fence and all you have is toothpicks. Oh and sorry because you may not be the right person to rant in the direction...
but seeing them listed out just made me go "argh".

This may need a small change record though?

Re-rollling machostache 's patch in comment #35.

Thanks @bradklaver!

This wasn't introduced by the reroll, but there's something broken. This also means we have little to no test coverage for the aggregator_summary_item theme hook (I hacked core to even get it to be used). The tests can probably be added in another issue, no need to hold this one up.

+++ b/core/modules/aggregator/aggregator.theme.inc
@@ -118,7 +118,7 @@ function template_preprocess_aggregator_summary_item(&$variables) {
   $variables['age'] = array(
     '#theme' => 'datetime',
     '#attributes' => array(
-      'datetime' => format_date($item->getPostedTime(), 'html_datetime', '', 'UTC'),
+      'time' => format_date($item->getPostedTime(), 'html_datetime', '', 'UTC'),
       'class' => array('feed-item-age',),
     ),
     '#text' => t('%age old', array('%age' => \Drupal::service('date')->formatInterval(REQUEST_TIME - $item->getPostedTime()))),

'#theme' should be changed to 'time' here and the attribute should remain as 'datetime'. See http://www.brucelawson.co.uk/2012/best-of-time/.

Addressed comment 41.

Issue to add tests created: #2325501: Add test coverage for output of aggregator_summary_item theme hook

This needs a small change record then it can be RTBC.

Working on the change record.

• Change record draft is up: https://www.drupal.org/node/2326617
• Added a note about '#type' => 'datetime' to the issue summary.
• Making a minor documentation tweak to the patch.

RTBC!

Patch is smaller because I have this in my .gitconfig:

[diff]
	renames = copies

Good catch.

Committed and pushed to 8.x. Thanks!