Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In #2075949: Add Libricons to messages, we came to the conclusion that the dblog module should update icon usage to SVG, following the new practices for implementation (see #2032773: Use Libricons (icon font) in Seven, consider using it more broadly in core).
This module uses the file "message-16-warning.png" at line 43 in dblog.module.css and "message-16-error.png" at line 49 in dblog.module.css
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | dblog-svg-icons.png | 178.61 KB | rteijeiro |
| #4 | dblog_libricons_2083945_4.patch | 1.03 KB | Outi |
Comments
Comment #1
klonos...less vague title (there are at least 3 issues with the same name: #2075949-10: Add Libricons to messages).
Comment #2
LewisNymantaggin
Comment #3
LewisNymanWorth having a quick look over the colours used, to see if we can align them with messages
Comment #4
Outi CreditAttribution: Outi commentedI made a patch with the svg icons we actually have.
By taking a look over the colors, do you mean the icon colors should be changed to match the message colors or the opposite? Anyway, the error icon color is now #ea2800 and the error message (border) color is #e62600. The warning icon color is #e29700 and the warning message (border) color is #e09600.
Comment #5
Outi CreditAttribution: Outi commentedComment #6
rteijeiro CreditAttribution: rteijeiro commentedTested the patch and seems good for me. (See screenshot)
SVG icons are loaded and also tried the no-svg fallback in IE8 and works well.
It's a RTBC for me.
Comment #7
LewisNymanIt was a bad idea to add colours to this issue, it's covered in #2070323: Apply seven style guide to dblog. The icons patch is RTBC.
Comment #8
webchickCommitted and pushed to 8.x. Thanks!
Comment #9.0
(not verified) CreditAttribution: commentedadded more info