Updated: Comment 0

Problem/Motivation

Attribute::value() uses a non existing property called value, so a notice happens. This method is not used anywhere in core.

  /**
   * Returns the whole array.
   */
  public function value() {
    return $this->value;
  }

Proposed resolution

  • Rename the method.
  • Write proper tests.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#3 attribute-2083941-3.patch5.26 KBdawehner
#3 interdiff.txt776 bytesdawehner
#1 template-attribute-2083941-1.patch5.26 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
Issue tags: +PHPUnit
FileSize
template-attribute-2083941-1.patch5.26 KB

There we go.

Status: Needs review » Needs work

The last submitted patch, template-attribute-2083941-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
interdiff.txt776 bytes
attribute-2083941-3.patch5.26 KB

That was the only I didn't tried whether it passes.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.