derived from #2061921: Remove calls to deprecated global $user in views module

Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']

All places in views plugin CachePluginBase.php of the views module should be fixed with $request properly injected

core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.php:

global $user;
CommentFileSizeAuthor
#7 2062169-7.patch2.97 KBalphawebgroup
#5 2062169-5.patch2.44 KBalphawebgroup
#1 vdc-cachepluginbase-2062169-1.patch2.44 KBalphawebgroup
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Status: Active » Needs review
FileSize
vdc-cachepluginbase-2062169-1.patch2.44 KB
victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented

Reviewed.

Status: Needs review » Needs work
Issue tags: -CodeSprintCIS

The last submitted patch, vdc-cachepluginbase-2062169-1.patch, failed testing.

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Status: Needs work » Needs review
Issue tags: +CodeSprintCIS

#1: vdc-cachepluginbase-2062169-1.patch queued for re-testing.

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
FileSize
2062169-5.patch2.44 KB

just retesting

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

We should always use the curent_user service :(

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Status: Needs work » Needs review
FileSize
2062169-7.patch2.97 KB

Status: Needs review » Needs work

The last submitted patch, 2062169-7.patch, failed testing.

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Status: Needs work » Closed (duplicate)
alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup commented
Issue summary: View changes

Updated issue summary.