When trying to download a project which requires a library and the sites/all/libraries folder does not exist, the parent folder of the library is not created. I suppose the same problem would occur if the sites/all/modules folder didn't exist.

prepareInstallDirectory() doesn't create installation directory when parent directory is writeable because the function is directly in the if (!is_writable($parent_dir)).

CommentFileSizeAuthor
#9 updater-installation_directory_not_created-2061333-9-no-whitespace-do-not-test.patch911 bytespfrenssen
#9 updater-installation_directory_not_created-2061333-9.patch2.79 KBpfrenssen
#7 updater-installation_directory_not_created-2061333-7.patch3.03 KBiSoLate
#1 updater-installation_directory_not_created-2061333-1.patch3.05 KBiSoLate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iSoLate’s picture

iSoLate CreditAttribution: iSoLate commented
FileSize
updater-installation_directory_not_created-2061333-1.patch3.05 KB

Did a fix for it. Thanks to Cyberwolf

iSoLate’s picture

iSoLate CreditAttribution: iSoLate commented
Assigned: iSoLate » Unassigned
Status: Active » Needs review
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Version: 7.23 » 7.x-dev
Component: other » update.module
Issue summary: View changes
Status: Needs review » Needs work 
+++ b/.gitignore
@@ -4,3 +4,4 @@ sites/*/settings*.php
+/nbproject/private/
\ No newline at end of file

You've accidentally added your Netbeans folder to the gitignore.

For the rest this looks good!

iSoLate’s picture

iSoLate CreditAttribution: iSoLate commented

Should be fixed now.

iSoLate’s picture

iSoLate CreditAttribution: iSoLate commented
Status: Needs work » Needs review
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented

Forgot to upload the new patch?

iSoLate’s picture

iSoLate CreditAttribution: iSoLate commented
FileSize
updater-installation_directory_not_created-2061333-7.patch3.03 KB

my bad :). uploaded now.

Status: Needs review » Needs work

The last submitted patch, 7: updater-installation_directory_not_created-2061333-7.patch, failed testing.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Needs work » Needs review
FileSize
updater-installation_directory_not_created-2061333-9.patch2.79 KB
updater-installation_directory_not_created-2061333-9-no-whitespace-do-not-test.patch911 bytes

Patch looks good now. It doesn't apply with git apply but it does apply cleanly with patch -p1. I've re-exported the patch with git so the bot can apply it. I did not make any changes to the patch itself. I've also provided a version that ignores whitespace changes so it is easier to see what is going on.

This is RTBC for me if the bot comes back green.